Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Build] fix overview default route #443

Merged
merged 1 commit into from
Jun 4, 2021

Conversation

kavilla
Copy link
Member

@kavilla kavilla commented Jun 4, 2021

Description

If default route was stored as kibana_overview, the default route will
modified in code to the updated opensearch_dashboards_overview.

Signed-off-by: Kawika Avilla [email protected]

Issues Resolved

#334

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

If default route was stored as kibana_overview, the default route will
modified in code to the updated opensearch_dashboards_overview.

Issues Partially Resolved:
opensearch-project#334

Signed-off-by: Kawika Avilla <[email protected]>
@opensearch-ci-bot
Copy link
Collaborator

✅   DCO Check Passed 35203d9

@kavilla kavilla added the build Build related additions or modifications label Jun 4, 2021
Copy link
Contributor

@boktorbb boktorbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Copy link
Contributor

@tmarkley tmarkley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks for adding the tests.

@kavilla kavilla merged commit d27cc92 into opensearch-project:main Jun 4, 2021
kavilla added a commit that referenced this pull request Jun 4, 2021
If default route was stored as kibana_overview, the default route will
modified in code to the updated opensearch_dashboards_overview.

Issues Partially Resolved:
#334

Signed-off-by: Kawika Avilla <[email protected]>
kavilla added a commit that referenced this pull request Jun 4, 2021
If default route was stored as kibana_overview, the default route will
modified in code to the updated opensearch_dashboards_overview.

Issues Partially Resolved:
#334

Signed-off-by: Kawika Avilla <[email protected]>
@kavilla kavilla deleted the avillk/overview_route branch June 4, 2021 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backwards-compatibility build Build related additions or modifications
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support restart upgrades to OpenSearch Dashboards 1.0 from Kibana v7.10.x
5 participants