-
Notifications
You must be signed in to change notification settings - Fork 917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Group ViewEvents option and bug fix #4309
Group ViewEvents option and bug fix #4309
Conversation
Signed-off-by: Ashish Agrawal <[email protected]>
Signed-off-by: Ashish Agrawal <[email protected]>
src/plugins/vis_augmenter/public/view_events_flyout/components/utils.tsx
Outdated
Show resolved
Hide resolved
src/plugins/visualizations/public/embeddable/visualize_embeddable.ts
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## feature/feature-anywhere #4309 +/- ##
=========================================================
Coverage 66.36% 66.36%
=========================================================
Files 3271 3271
Lines 62995 62997 +2
Branches 9756 9758 +2
=========================================================
+ Hits 41808 41810 +2
Misses 18840 18840
Partials 2347 2347
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: Ashish Agrawal <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
src/plugins/vis_augmenter/public/view_events_flyout/components/utils.tsx
Outdated
Show resolved
Hide resolved
Signed-off-by: Ashish Agrawal <[email protected]>
Description
Group ViewEvents option and bug fixes
Issues Resolved
N/A
Testing the changes
Manual testing with the Alerting and AD plugins
Check List
yarn test:jest
yarn test:jest_integration
yarn test:ftr