Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge main changes to Feature-Anywhere branch #4295

Merged

Conversation

lezzago
Copy link
Member

@lezzago lezzago commented Jun 15, 2023

Description

Merge main changes to Feature-Anywhere branch

Issues Resolved

N/A

Testing the changes

Ran local cluster and setup on a remote test cluster with the distributions built.

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
    • yarn test:ftr
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

opensearch-trigger-bot bot and others added 30 commits April 22, 2023 04:35
* fixes header change
* Update src/core/public/chrome/ui/header/header_help_menu.tsx
* fixes snapshots



---------



(cherry picked from commit 3cca088)

Signed-off-by: Ashwin P Chandran <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Josh Romero <[email protected]>
…pensearch-project#3922)

History push will just to the current route. However, dashboardsProvider
was implemented with the expectation that it was a different app.

So when a plugin registered it was attempting to navigate to
`app/dashboard#/app/{url}`

Add tests and extra data test subject.

Signed-off-by: Kawika Avilla <[email protected]>
* Update js-yaml to 4.0.5 (opensearch-project#3659)
* Update CHANGELOG.md (opensearch-project#3659)

Co-authored-by: Sergey Myssak <[email protected]>
Signed-off-by: Andrey Myssak <[email protected]>

---------

Signed-off-by: Andrey Myssak <[email protected]>
Signed-off-by: Josh Romero <[email protected]>
Co-authored-by: Sergey Myssak <[email protected]>
Co-authored-by: Josh Romero <[email protected]>
* Update README.md

Signed-off-by: Melissa Vagi <[email protected]>

* Update README.md

Co-authored-by: Miki <[email protected]>

---------

Signed-off-by: Melissa Vagi <[email protected]>
Co-authored-by: Miki <[email protected]>
Co-authored-by: Miki <[email protected]>
Signed-off-by: Manasvini B Suryanarayana <[email protected]>
Co-authored-by: Sean Neumann <[email protected]>
* docs(COMMUNICATION): Add communication guide

with info on slack, forum, and developer office hours
link from README, CONTRIBUTING, DEVELOPER_GUIDE

Signed-off-by: Josh Romero <[email protected]>

---------

Signed-off-by: Josh Romero <[email protected]>
…pensearch-project#3976)

The latest version of chromedriver is 112.0.1 which does not support
node 14. This PR hardcodes chromedriver to 112.0.0 temporarily. Pls
revert it once we bump to node 18.

Issue Resolved
opensearch-project#3975

Signed-off-by: ananzh <[email protected]>
…ch-project#3911)

* Fix wording and duplicate code in embeddable example plugin

Signed-off-by: abbyhu2000 <[email protected]>

* Fix some wording in the embeddable readme

Signed-off-by: abbyhu2000 <[email protected]>

---------

Signed-off-by: abbyhu2000 <[email protected]>
Within the CI, the virtual runner that we are utilizing has Chrome
installed already. The version of Chrome is installed periodically.

The most recent version of Chrome requires updates to dependencies
that drop support for Node 14.

This downloads chrome in the CI and then checks the chromedriver
from the environment variable `TEST_BROWSER_BINARY_PATH`.

Signed-off-by: Kawika Avilla <[email protected]>
Initial page size was passed to the search function instead
of the listing limit causing the max amount received to be
significantly less than the previously implementation.

Saved objects per page is `20` by default and the listing
limit per page is `1000` by default.

Issue:
opensearch-project#4017

Signed-off-by: Kawika Avilla <[email protected]>
* Update find_test_subject imports for tests

Signed-off-by: Alexei Karikov <[email protected]>

* Update to available imports for findTestSubject

Signed-off-by: Alexei Karikov <[email protected]>

* Fix available import for Query and custom icon

Signed-off-by: Alexei Karikov <[email protected]>

* Add changelog entry

Signed-off-by: Alexei Karikov <[email protected]>

* Add ts-ignore

Signed-off-by: Alexei Karikov <[email protected]>

---------

Signed-off-by: Alexei Karikov <[email protected]>
Co-authored-by: Qingyang(Abby) Hu <[email protected]>
…ct#4040)

* Fixes code coverage workflow failures for the project test due to inderect flakey changes

Signed-off-by: Ashwin P Chandran <[email protected]>

* Adds changelog

Signed-off-by: Ashwin P Chandran <[email protected]>

---------

Signed-off-by: Ashwin P Chandran <[email protected]>
…oject#3908)

Remove re2 usage and replace it with JavaScript built-in
RegExp object. Also add more unit tests to make sure that
using RegExp has same expressions as using re2 library.

Issue Resolve
opensearch-project#3901

Signed-off-by: Anan Zhuang <[email protected]>
…nsearch-project#3993)

* remove unused ul element

Signed-off-by: Sirazh Gabdullin <[email protected]>

* Update CHANGELOG.md

Signed-off-by: Sirazh Gabdullin <[email protected]>

---------

Signed-off-by: Sirazh Gabdullin <[email protected]>
…#4063)

* Add release note for 1.3.10



* Address comments and add one CVE PR



---------


(cherry picked from commit 4371587)

Signed-off-by: abbyhu2000 <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…h-project#3957)

* [Multiple Datasource]Support Amazon OpenSearch Serverless in SigV4
* remove experimental text in yml
* Refactor create data source form for authentication

Signed-off-by: Su <[email protected]>
* Remove Sass from tile_map plugin

Signed-off-by: Matt Provost <[email protected]>

* Update changelog

Signed-off-by: Matt Provost <[email protected]>

---------

Signed-off-by: Matt Provost <[email protected]>
…pensearch-project#3954)

* Adds design document for new saved object service interface for custom repository

Signed-off-by: Bandini Bhopi <[email protected]>
* enhance grouping for context menu options
* build panels tests and more comments

Signed-off-by: David Sinclair <[email protected]>

---------

Signed-off-by: David Sinclair <[email protected]>
Signed-off-by: David Sinclair <[email protected]>
Signed-off-by: Josh Romero <[email protected]>
Co-authored-by: Josh Romero <[email protected]>
* Adding Tao and Zilong to MAINTAINERS

Signed-off-by: Yan Zeng <[email protected]>
* Bump Node.js requirements to 18

Signed-off-by: Miki <[email protected]>

* Replace `lmdb-store` with `lmdb`

Signed-off-by: Miki <[email protected]>
Co-authored-by: Anan Zhuang <[email protected]>

* Bump `elastic-apm-node` to the latest minor

Signed-off-by: Miki <[email protected]>

* Replace webpack and plugins with a patched version that uses xxhash64
* Use `xxhash64` as the hashing algorithm of webpack
* Upgrade `globby`
* Remove `fibers`

Signed-off-by: Miki <[email protected]>

* Replace `fs.rmdir` with `fs.rm` in cross-platform tests

Signed-off-by: Miki <[email protected]>

* Increase listener limit

Signed-off-by: Miki <[email protected]>
Co-authored-by: Anan Zhuang <[email protected]>

* Add promise-stripping serializer

Signed-off-by: Miki <[email protected]>

* Bump heap for CI

Signed-off-by: Miki <[email protected]>

* Correct use of fs/promises in @osd/pm

Signed-off-by: Miki <[email protected]>

* Use fs/promise in plugin post-install cleanup

Signed-off-by: Miki <[email protected]>

* Set the test server's host to `0.0.0.0`

Signed-off-by: Miki <[email protected]>

* Sync `.node-version` file

Signed-off-by: Miki <[email protected]>

* Support both `isPrimary`, for Node 18, and `isMaster`, for Node 14

Signed-off-by: Miki <[email protected]>

* Add types when using `isDeepStrictEqual`

Signed-off-by: Miki <[email protected]>
Co-authored-by: Anan Zhuang <[email protected]>

* Add names to `SchemaError` to log more specific errors

Signed-off-by: Miki <[email protected]>

* Fix failing vega visualization tests outside the CI

Signed-off-by: Miki <[email protected]>

* Fix snapshot of errors thrown for undefined accessors

Signed-off-by: Miki <[email protected]>

* Fix flakiness of log_rotator

Signed-off-by: Miki <[email protected]>

* Fix asynchronous `fs` usafe in plugin discover

Signed-off-by: Miki <[email protected]>

* Fix mocks in @osd/optimizer

Signed-off-by: Miki <[email protected]>

* Fix memory leaks caused by setting states on unloaded components

Signed-off-by: Miki <[email protected]>
Co-authored-by: Anan Zhuang <[email protected]>

* Bump Node in Dockerfile

Signed-off-by: Miki <[email protected]>
Co-authored-by: Anan Zhuang <[email protected]>

* Remove the response `close` event as an indicator of the requesting finishing

opensearch-project#3601 (comment)

Signed-off-by: Miki <[email protected]>
Co-authored-by: Anan Zhuang <[email protected]>

* [BWC] Timeout after 3 mins of waiting for OSD to be running in tests

Signed-off-by: Miki <[email protected]>

* Make build use the same node version that tests are run against

Signed-off-by: Miki <[email protected]>

* Make Node resolve DNS by IPv4 first
* This is helpful to resolve `locahost` to `127.0.0.1`

Signed-off-by: Miki <[email protected]>

* Standardize patterns used by plugin discovery
* Enhance absolute path serialization on  Windows

Signed-off-by: Miki <[email protected]>

* Mock fetch in SenseEditor tests

Signed-off-by: Miki <[email protected]>

* Restore node-sass usage to fix build performance

* `sass-loader@10` is the last version that supports webpack@4
* `sass` is extremely slow when using the legacy API (`render`) and to use the "Modern API" (`compileStringAsync`), `sass-loader@13` would be needed.
* The performance of `sass@10` is made acceptable only with `fibers` but that is deprecated and doesn't work on Node 18

Signed-off-by: Anan Zhuang <[email protected]>
Signed-off-by: Miki <[email protected]>

* Revert "[CI] setup Chrome and utilize binary path (opensearch-project#3997)"

This reverts commit 0188d05

Signed-off-by: Miki <[email protected]>

* Prevent fast-fail while running functional test in CI

Signed-off-by: Miki <[email protected]>

* Revert "Temporarily hardcode chromedriver to 112.0.0 to enable all ftr tests (opensearch-project#3976)"

This reverts commit 5ea0cbe.

Signed-off-by: Miki <[email protected]>

* Save Cypress results artifacts during CI

Signed-off-by: Miki <[email protected]>

* Add missing required dependency on `set-value`

* Also force all to ^4.1.0 due to a vulnerability fixed in 3.1.0.

Signed-off-by: Miki <[email protected]>

* Prevent multiple calls to bootstrap's shutdown

Signed-off-by: Miki <[email protected]>

* Use Node 18.16.0 in distributions

* Bump jest-canvas-mock to fix failing tests
* Extend Node engines versions

Signed-off-by: Miki <[email protected]>

* Normalize test snapshots across Node 14, 16, and 18

Signed-off-by: Miki <[email protected]>

* Update CHANGELOG for Node.js >=14.20.1 <19 support

Signed-off-by: Miki <[email protected]>

---------

Signed-off-by: Miki <[email protected]>
Signed-off-by: Miki <[email protected]>
Signed-off-by: Anan Zhuang <[email protected]>
Co-authored-by: Anan Zhuang <[email protected]>
* Remove timeline application

In this PR, we made the following changes:
First of all, clean out some advanced settings specific to timeline
application and tests.
* Remove timelion:default_rows: This setting defines the default
number of rows that a new Timelion sheet should have.
* Remove timelion:default_rows: This setting defines the default
number of columns that a new Timelion sheet should have.
* Remove timelion:showTutorial.

Second, remove src/plugin/timeline completely and modify timeline vis.
Third, remove all the functional tests related to timeline application.

Issue resolve
opensearch-project#3519
opensearch-project#3593

Signed-off-by: ananzh <[email protected]>

---------

Signed-off-by: Anan Zhuang <[email protected]>
Signed-off-by: ananzh <[email protected]>
AMoo-Miki and others added 13 commits May 30, 2023 13:50
…#4188)

Snapshot checksum verification caused failure in test runs:
opensearch-project#4187

Skipping the verification to enable the tests run as the snapshot
of OpenSearch should not impact the tests.

Issue:
n/a

Signed-off-by: Kawika Avilla <[email protected]>
…d verifies if it is installed (opensearch-project#3116)

Resolves Issue -opensearch-project#2799

Signed-off-by: Manasvini B Suryanarayana <[email protected]>
…favor of OUI utility class. (opensearch-project#4164)

* remove custom styling in favor of oui utility class

Signed-off-by: Sirazh Gabdullin <[email protected]>

* Update CHANGELOG.md

Signed-off-by: Sirazh Gabdullin <[email protected]>

---------

Signed-off-by: Sirazh Gabdullin <[email protected]>
* Add new code owners

Signed-off-by: Tao Liu <[email protected]>

* modify changelog.md

Signed-off-by: Tao Liu <[email protected]>

---------

Signed-off-by: Tao Liu <[email protected]>
* Add 2.8.0 release notes

Co-authored-by: Josh Romero <[email protected]>
Signed-off-by: Kawika Avilla <[email protected]>
)

* Chore(CHANGELOG): Update with 2.7 release
* align changelog with 2.8 release notes
* update 2.8 release notes
* add 1.3.10 release notes to changelog

---------

Signed-off-by: Josh Romero <[email protected]>
…roject#4149)

* Adds Repository Factory Provider

Signed-off-by: Bandini Bhopi <[email protected]>
* enhance grouping for context menu options

Signed-off-by: David Sinclair <[email protected]>

* change log

Signed-off-by: David Sinclair <[email protected]>

* remove type export

Signed-off-by: David Sinclair <[email protected]>

* revert border and prevent destroy options

Signed-off-by: David Sinclair <[email protected]>

* update comments for building panels

Signed-off-by: David Sinclair <[email protected]>

* build panels tests and more comments

Signed-off-by: David Sinclair <[email protected]>

* add category option for context menus

Signed-off-by: David Sinclair <[email protected]>

* changelog

Signed-off-by: David Sinclair <[email protected]>

* add order to groups

Signed-off-by: David Sinclair <[email protected]>

* documentation, shorter copyrighty, minor cleanup

Signed-off-by: David Sinclair <[email protected]>

* changelog

Signed-off-by: David Sinclair <[email protected]>

---------

Signed-off-by: David Sinclair <[email protected]>
Signed-off-by: David Sinclair <[email protected]>
Signed-off-by: Ashish Agrawal <[email protected]>
Co-authored-by: Ashish Agrawal <[email protected]>
…-project#4026)

* Add bluebird replaces for src/plugins/saved_objects
* Add changelog entry

---------

Signed-off-by: Alexei Karikov <[email protected]>
@codecov
Copy link

codecov bot commented Jun 15, 2023

Codecov Report

Merging #4295 (99f7c37) into feature/feature-anywhere (83e2ff9) will decrease coverage by 0.05%.
The diff coverage is 88.23%.

@@                     Coverage Diff                      @@
##           feature/feature-anywhere    #4295      +/-   ##
============================================================
- Coverage                     66.35%   66.31%   -0.05%     
============================================================
  Files                          3271     3271              
  Lines                         62947    62995      +48     
  Branches                       9741     9756      +15     
============================================================
+ Hits                          41768    41774       +6     
- Misses                        18836    18869      +33     
- Partials                       2343     2352       +9     
Flag Coverage Δ
Linux ?
Windows 66.31% <88.23%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/core/server/legacy/legacy_service.ts 75.38% <ø> (ø)
src/core/server/plugins/plugin_context.ts 45.45% <ø> (ø)
src/core/server/plugins/types.ts 100.00% <ø> (ø)
...server/saved_objects/saved_objects_service.mock.ts 100.00% <ø> (ø)
...aved_objects/service/lib/scoped_client_provider.ts 100.00% <ø> (ø)
...pe_table/public/components/table_vis_component.tsx 100.00% <ø> (ø)
...lic/context_menu/build_eui_context_menu_panels.tsx 76.00% <80.00%> (+0.39%) ⬆️
src/core/server/plugins/plugins_system.ts 90.32% <85.71%> (-0.82%) ⬇️
...server/plugins/discovery/plugin_manifest_parser.ts 84.37% <100.00%> (+2.23%) ⬆️
src/core/server/plugins/plugin.ts 100.00% <100.00%> (ø)
... and 1 more

... and 7 files with indirect coverage changes

@lezzago lezzago merged commit 2362c35 into opensearch-project:feature/feature-anywhere Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.