Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor hardcode color to use OUI in maps_legacy #4294

Merged
merged 5 commits into from
Jun 26, 2023
Merged

Refactor hardcode color to use OUI in maps_legacy #4294

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b081bf7
Refactor color to use OUI
BSFishy Jun 15, 2023
4c9bb1d
Pull theme value from actual active theme
BSFishy Jun 15, 2023
964339d
Update changelog
BSFishy Jun 15, 2023
f75a277
Merge branch 'main' into update_const_color
ananzh Jun 22, 2023
9f74ec5
Merge branch 'main' into update_const_color
joshuarrrr Jun 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@ Inspired from [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
- Remove unused Sass in `tile_map` plugin ([#4110](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/4110))
- [Table Visualization] Remove custom styling for text-align:center in favor of OUI utility class. ([#4164](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/4164))
- Replace the use of `bluebird` in `saved_objects` plugin ([#4026](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/4026))
- Replace hardcode color to OUI color in `maps_legacy` plugin ([#4294](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/4294))

### 🔩 Tests

Expand Down
3 changes: 2 additions & 1 deletion src/plugins/maps_legacy/public/map/opensearch_dashboards_map.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ import { i18n } from '@osd/i18n';
import { ORIGIN } from '../common/constants/origin';
import { getToasts } from '../opensearch_dashboards_services';
import { L } from '../leaflet';
import { euiThemeVars } from '@osd/ui-shared-deps/theme';

function makeFitControl(fitContainer, opensearchDashboardsMap) {
// eslint-disable-next-line no-undef
Expand Down Expand Up @@ -474,7 +475,7 @@ export class OpenSearchDashboardsMap extends EventEmitter {
}

addDrawControl() {
const drawColor = '#000';
const drawColor = euiThemeVars.euiColorInk;
const drawOptions = {
draw: {
polyline: false,
Expand Down