Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CHANGELOG with new 2.8.0/2.7.0 sections and clean-up unreleased section #4283

Merged
merged 1 commit into from
Jun 23, 2023

Conversation

manasvinibs
Copy link
Member

Description

For 2.x branch:

  • Update CHANGELOG in 2.x so that there's a 2.8.0 section that matches the 2.8.0 release notes.
  • Add 2.8.0 release date
  • For any PRs released in 2.8.0, remove from the "Unreleased" section
  • Validate that "Unreleased" section is accurate

Issues Resolved

#4263

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
    • yarn test:ftr
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

ananzh
ananzh previously approved these changes Jun 14, 2023
Copy link
Member

@joshuarrrr joshuarrrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, just need to remove the 2.x header. At first I was surprised to see the welcome messages here, but it's growing on me. If we keep them, we should add a placeholder header to the unreleased section so we remember to include for 2.9.

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@manasvinibs
Copy link
Member Author

This looks great, just need to remove the 2.x header. At first I was surprised to see the welcome messages here, but it's growing on me. If we keep them, we should add a placeholder header to the unreleased section so we remember to include for 2.9.

Thanks Josh for the review! Updated.

@manasvinibs manasvinibs requested review from joshuarrrr and ananzh June 14, 2023 18:53
zhongnansu
zhongnansu previously approved these changes Jun 15, 2023
Flyingliuhub
Flyingliuhub previously approved these changes Jun 16, 2023
joshuarrrr
joshuarrrr previously approved these changes Jun 23, 2023
@manasvinibs manasvinibs requested a review from joshuarrrr June 23, 2023 20:18
@ananzh ananzh merged commit 8db23c9 into opensearch-project:2.x Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants