Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Anywhere] Expose external services to helper fns #4139

Merged

Conversation

ohltyler
Copy link
Member

Description

There is an issue where plugins running helper fns from visAugmenter are failing, due to the visAugmenter plugin's services showing as not being set. Detail on issue: see #4138

To fix this for now, we can update the helper fns to take in plugin-set services, which are defined.

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
    • yarn test:ftr
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@codecov
Copy link

codecov bot commented May 25, 2023

Codecov Report

Merging #4139 (f984f14) into feature/feature-anywhere (ec4c1df) will increase coverage by 0.05%.
The diff coverage is 25.00%.

@@                     Coverage Diff                      @@
##           feature/feature-anywhere    #4139      +/-   ##
============================================================
+ Coverage                     66.44%   66.50%   +0.05%     
============================================================
  Files                          3247     3247              
  Lines                         62553    62553              
  Branches                       9659     9662       +3     
============================================================
+ Hits                          41563    41600      +37     
+ Misses                        18676    18644      -32     
+ Partials                       2314     2309       -5     
Flag Coverage Δ
Linux 66.44% <25.00%> (+<0.01%) ⬆️
Windows 66.44% <25.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/plugins/vis_augmenter/public/utils/utils.ts 90.69% <0.00%> (-2.33%) ⬇️
...ugmenter/public/saved_augment_vis/utils/helpers.ts 6.66% <33.33%> (ø)

... and 9 files with indirect coverage changes

@lezzago lezzago merged commit 66070aa into opensearch-project:feature/feature-anywhere May 30, 2023
@kavilla kavilla added v2.9.0 and removed v2.8.0 labels Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants