Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CCI] Attach Notification bar (OuiBottomBar) to the top of Settings container #3949

Conversation

SergeyMyssak
Copy link
Contributor

Description

Attached Notification bar (OuiBottomBar) to the top of Settings container

Screen.Recording.2023-04-26.at.10.51.16.mov

Issues Resolved

#3336

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
    • yarn test:ftr
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Verified

This commit was signed with the committer’s verified signature.
ChrisKujawa Christopher Kujawa (Zell)
Co-authored-by: Andrey Myssak <[email protected]>
Signed-off-by: Sergey Myssak <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Apr 26, 2023

Codecov Report

Merging #3949 (a8b03cc) into main (755f16b) will decrease coverage by 0.01%.
The diff coverage is 75.00%.

❗ Current head a8b03cc differs from pull request most recent head b20fa53. Consider uploading reports for the commit b20fa53 to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main    #3949      +/-   ##
==========================================
- Coverage   66.44%   66.43%   -0.01%     
==========================================
  Files        3229     3229              
  Lines       62068    62066       -2     
  Branches     9599     9598       -1     
==========================================
- Hits        41238    41232       -6     
- Misses      18527    18530       +3     
- Partials     2303     2304       +1     
Flag Coverage Δ
Linux 66.37% <75.00%> (-0.01%) ⬇️
Windows 66.38% <75.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ngs/public/management_app/components/form/form.tsx 70.10% <75.00%> (-0.61%) ⬇️

... and 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ashwin-pc
Copy link
Member

Closing this in favour of #3978

@ashwin-pc ashwin-pc closed this May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants