Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Build] restore timelion #390

Merged
merged 1 commit into from
Jun 3, 2021

Conversation

kavilla
Copy link
Member

@kavilla kavilla commented May 29, 2021

Description

Restoring the timeline to timelion within the code and then updated the tests
(unit, integ, and func test all passing). This is allowable because
this is for functional purposes and for clusters/plugins that will
migrate to Dashboards. Their index will not require re-indexing for 1.0.0
and shouldn't require a full migration after further updates.

Signed-off-by: Kawika Avilla [email protected]

Issues Resolved

Partial: #334

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

@opensearch-ci-bot
Copy link
Collaborator

✅   DCO Check Passed e108e6d

@kavilla kavilla force-pushed the avillk/restore_timelion_4 branch from e108e6d to 46dd806 Compare May 29, 2021 09:37
@opensearch-ci-bot
Copy link
Collaborator

✅   DCO Check Passed 46dd806

Copy link
Contributor

@mihirsoni mihirsoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good to me..Thanks for working long on this. Just have one comment rest looks good to me.

@opensearch-ci-bot
Copy link
Collaborator

✅   DCO Check Passed baba45a

@kavilla kavilla force-pushed the avillk/restore_timelion_4 branch from baba45a to 7da03c9 Compare June 1, 2021 01:55
@opensearch-ci-bot
Copy link
Collaborator

✅   DCO Check Passed 7da03c9

@opensearch-ci-bot
Copy link
Collaborator

✅   DCO Check Passed b96e82d

@opensearch-ci-bot
Copy link
Collaborator

✅   DCO Check Passed 4dfd36e

Restoring the timeline to timelion and then updated the tests
(unit, integ, and func test all passing). This is allowable because
this is for functional purposes and for clusters/plugins that will
migrate to Dashboards. Their index will not require re-indexing for 1.0.0
and shouldn't require a full migration after further updates.

Update telemetry usage to be timelion

Clean up code

Signed-off-by: Kawika Avilla <[email protected]>
@kavilla kavilla force-pushed the avillk/restore_timelion_4 branch from 4dfd36e to a87e218 Compare June 2, 2021 00:33
@opensearch-ci-bot
Copy link
Collaborator

✅   DCO Check Passed a87e218

@kavilla kavilla requested review from mihirsoni and tmarkley June 2, 2021 00:40
Copy link
Contributor

@tmarkley tmarkley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kavilla kavilla merged commit 95f4fd5 into opensearch-project:main Jun 3, 2021
kavilla added a commit that referenced this pull request Jun 3, 2021
Restoring the timeline to timelion and then updated the tests
(unit, integ, and func test all passing). This is allowable because
this is for functional purposes and for clusters/plugins that will
migrate to Dashboards. Their index will not require re-indexing for 1.0.0
and shouldn't require a full migration after further updates.

Update telemetry usage to be timelion

Clean up code

Signed-off-by: Kawika Avilla <[email protected]>
kavilla added a commit that referenced this pull request Jun 3, 2021
Restoring the timeline to timelion and then updated the tests
(unit, integ, and func test all passing). This is allowable because
this is for functional purposes and for clusters/plugins that will
migrate to Dashboards. Their index will not require re-indexing for 1.0.0
and shouldn't require a full migration after further updates.

Update telemetry usage to be timelion

Clean up code

Signed-off-by: Kawika Avilla <[email protected]>
@kavilla kavilla deleted the avillk/restore_timelion_4 branch June 3, 2021 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support restart upgrades to OpenSearch Dashboards 1.0 from Kibana v7.10.x
5 participants