-
Notifications
You must be signed in to change notification settings - Fork 916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Build] restore timelion #390
[Build] restore timelion #390
Conversation
✅ DCO Check Passed e108e6d |
e108e6d
to
46dd806
Compare
✅ DCO Check Passed 46dd806 |
src/plugins/opensearch_dashboards_usage_collection/server/collectors/management/schema.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good to me..Thanks for working long on this. Just have one comment rest looks good to me.
✅ DCO Check Passed baba45a |
baba45a
to
7da03c9
Compare
✅ DCO Check Passed 7da03c9 |
7da03c9
to
b96e82d
Compare
✅ DCO Check Passed b96e82d |
✅ DCO Check Passed 4dfd36e |
Restoring the timeline to timelion and then updated the tests (unit, integ, and func test all passing). This is allowable because this is for functional purposes and for clusters/plugins that will migrate to Dashboards. Their index will not require re-indexing for 1.0.0 and shouldn't require a full migration after further updates. Update telemetry usage to be timelion Clean up code Signed-off-by: Kawika Avilla <[email protected]>
4dfd36e
to
a87e218
Compare
✅ DCO Check Passed a87e218 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Restoring the timeline to timelion and then updated the tests (unit, integ, and func test all passing). This is allowable because this is for functional purposes and for clusters/plugins that will migrate to Dashboards. Their index will not require re-indexing for 1.0.0 and shouldn't require a full migration after further updates. Update telemetry usage to be timelion Clean up code Signed-off-by: Kawika Avilla <[email protected]>
Restoring the timeline to timelion and then updated the tests (unit, integ, and func test all passing). This is allowable because this is for functional purposes and for clusters/plugins that will migrate to Dashboards. Their index will not require re-indexing for 1.0.0 and shouldn't require a full migration after further updates. Update telemetry usage to be timelion Clean up code Signed-off-by: Kawika Avilla <[email protected]>
Description
Restoring the timeline to timelion within the code and then updated the tests
(unit, integ, and func test all passing). This is allowable because
this is for functional purposes and for clusters/plugins that will
migrate to Dashboards. Their index will not require re-indexing for 1.0.0
and shouldn't require a full migration after further updates.
Signed-off-by: Kawika Avilla [email protected]
Issues Resolved
Partial: #334
Check List