Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resolved get_keystore unit test #3854

Merged
merged 5 commits into from
Apr 17, 2023
Merged

resolved get_keystore unit test #3854

merged 5 commits into from
Apr 17, 2023

Conversation

Aigerim-ai
Copy link
Contributor

@Aigerim-ai Aigerim-ai commented Apr 16, 2023 •
edited
Loading

Description

This commit fixes #773

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
    • yarn test:ftr
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@Aigerim-ai Aigerim-ai changed the title resolving get_keystore unit test resolved get_keystore unit test Apr 16, 2023
@codecov-commenter
Copy link

codecov-commenter commented Apr 16, 2023 •
edited
Loading

Codecov Report

Merging #3854 (d8b845e) into main (8f890e9) will not change coverage.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##             main    #3854   +/-   ##
=======================================
  Coverage   66.42%   66.42%           
=======================================
  Files        3209     3209           
  Lines       61733    61733           
  Branches     9534     9534           
=======================================
  Hits        41008    41008           
  Misses      18438    18438           
  Partials     2287     2287
Flag Coverage Δ
Linux 66.37% <ø> (ø)
Windows 66.37% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Aigerim-ai
Copy link
Contributor Author

@abbyhu2000 hi! can you please look at this commit?

@Aigerim-ai Aigerim-ai closed this Apr 17, 2023
@Aigerim-ai Aigerim-ai reopened this Apr 17, 2023
@abbyhu2000 abbyhu2000 self-assigned this Apr 17, 2023
@abbyhu2000 abbyhu2000 added the OSCI Open Source Contributor Initiative label Apr 17, 2023
@abbyhu2000
Copy link
Member

@abbyhu2000 hi! can you please look at this commit?

LGTM! Thank you @Aigerim-ai

abbyhu2000
abbyhu2000 previously approved these changes Apr 17, 2023
View reviewed changes
manasvinibs
manasvinibs reviewed Apr 17, 2023
View reviewed changes
CHANGELOG.md Outdated
@@ -192,8 +192,10 @@ Inspired from [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
- [Vis Builder] Adds field unit tests ([#3211](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/3211))
- [BWC Tests] Add BWC tests for 2.6.0 ([#3356](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/3356))
- Prevent primitive linting limitations from being applied to unit tests found under `src/setup_node_env` ([#3403](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/3403))
- [Tests] Resolves the issue with get_keystore.js test([#3854]https://github.com/opensearch-project/OpenSearch-Dashboards/pull/3854)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: should be ([#3854](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/3854))

AMoo-Miki
AMoo-Miki requested changes Apr 17, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
src/cli_keystore/get_keystore.test.js
@@ -32,6 +32,8 @@ import { getKeystore } from './get_keystore';
import { Logger } from '../cli_plugin/lib/logger';
import fs from 'fs';
import sinon from 'sinon';
import { getConfigDirectory, getDataPath } from '@osd/utils';
import { join } from 'path';
Copy link
Collaborator

@AMoo-Miki AMoo-Miki Apr 17, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this work on Windows too?

It clearly does as the tests pass.

@manasvinibs
Copy link
Member

@abbyhu2000 Changes have to be rebased as there is a merge conflict and also DCO check is failing.

AMoo-Miki
AMoo-Miki previously approved these changes Apr 17, 2023
View reviewed changes
@Aigerim-ai @abbyhu2000
resolving get_keystore unit test
7bbfb25 
Signed-off-by: Aigerim Suleimenova <[email protected]>
@Aigerim-ai @abbyhu2000
test
e8d46be 
Signed-off-by: Aigerim Suleimenova <[email protected]>
@AMoo-Miki
Copy link
Collaborator

The required commits have been signed-off; will pass DCO.

abbyhu2000 and others added 2 commits April 17, 2023 17:55
@abbyhu2000 @AMoo-Miki
Update CHANGELOG.md
7097f1b 
Co-authored-by: Miki <[email protected]>
Signed-off-by: abbyhu2000 <[email protected]>
@abbyhu2000
Update CHANGELOG.md
b172eef 
Fix Changelog entry format

Signed-off-by: abbyhu2000 <[email protected]>
@abbyhu2000 abbyhu2000 merged commit 677dcbd into opensearch-project:main Apr 17, 2023
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Apr 17, 2023
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Apr 17, 2023
@github-actions
resolved get_keystore unit test (#3854)
90c233c 
(cherry picked from commit 677dcbd)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md
abbyhu2000 pushed a commit that referenced this pull request Apr 17, 2023
@opensearch-trigger-bot @github-actions
resolved get_keystore unit test (#3854) (#3864)
e676534 
(cherry picked from commit 677dcbd)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
sikhote pushed a commit to sikhote/OpenSearch-Dashboards that referenced this pull request Apr 24, 2023
@Aigerim-ai @sikhote
resolved get_keystore unit test (opensearch-project#3854)
59d001d 
Signed-off-by: David Sinclair <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manasvinibs manasvinibs manasvinibs approved these changes

@abbyhu2000 abbyhu2000 abbyhu2000 approved these changes

@AMoo-Miki AMoo-Miki AMoo-Miki left review comments

@ananzh ananzh Awaiting requested review from ananzh ananzh is a code owner

@kavilla kavilla Awaiting requested review from kavilla kavilla is a code owner

@seanneumann seanneumann Awaiting requested review from seanneumann

@ashwin-pc ashwin-pc Awaiting requested review from ashwin-pc ashwin-pc is a code owner

@joshuarrrr joshuarrrr Awaiting requested review from joshuarrrr joshuarrrr is a code owner

@zengyan-amazon zengyan-amazon Awaiting requested review from zengyan-amazon zengyan-amazon is a code owner

@kristenTian kristenTian Awaiting requested review from kristenTian

@zhongnansu zhongnansu Awaiting requested review from zhongnansu zhongnansu is a code owner

Assignees

@abbyhu2000 abbyhu2000

Labels
backport 2.x first-time-contributor OSCI Open Source Contributor Initiative v2.7.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] get_keystore test using absolute path
5 participants
@Aigerim-ai @codecov-commenter @abbyhu2000 @manasvinibs @AMoo-Miki