[Build] restore esTypes #377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kavilla
added
build
|
✅ DCO Check Passed 96d5bd3 |
dblock
previously approved these changes
May 26, 2021
tmarkley
previously approved these changes
May 26, 2021
Restoring the opensearchTypes to esTypes and then updated the tests (unit, integ, and func test all passing). This is allowable because this is for functional purposes and for clusters/plugins that will migrate to Dashboards. Their index will not require re-indexing for 1.0.0 and shouldn't require a full migration after further updates. Signed-off-by: Kawika Avilla <[email protected]>
kavilla
force-pushed
the
avillk/restore_esTypes
branch
from
96d5bd3 to
43f8583
Compare
|
✅ DCO Check Passed 43f8583 |
tmarkley
approved these changes
May 26, 2021
kavilla
added a commit
that referenced
this pull request
May 26, 2021
Restoring the opensearchTypes to esTypes and then updated the tests (unit, integ, and func test all passing). This is allowable because this is for functional purposes and for clusters/plugins that will migrate to Dashboards. Their index will not require re-indexing for 1.0.0 and shouldn't require a full migration after further updates. Signed-off-by: Kawika Avilla <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
NOTE: for purposes of moving forward I branched off #375. Once I am able to merge in restoring the previous change, which will be merged in first, I will rebase and drop commits: 234a703 and 22ce5c8. Just wanted to give people a change to review these changes as soon as possible. If you are reading this please only review the contents of 96d5bd3 .
Restoring the opensearchTypes to esTypes and then updated the tests
(unit, integ, and func test all passing). This is allowable because
this is for functional purposes and for clusters/plugins that will
migrate to Dashboards. Their index will not require re-indexing for 1.0.0
and shouldn't require a full migration after further updates.
Signed-off-by: Kawika Avilla [email protected]
Issues Resolved
Partial: #334
Check List