Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] [Chore] Update timeline default expression #3697

Merged
merged 2 commits into from
Mar 28, 2023

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 7efc231 from #2720.

* [Chore] Update other timeline `es()` examples and test usage to make sure we continue supporting the old format.
* [Chore] Update BWC data generation to use es(*)
* [Test] Add better programmatic text clearing for monaco editor
* [Test] Wait for loader to finish after clicking update

Update default expression from `.es(*)` to `opensearch(*)`.
Both work, but we'd prefer the latter

Signed-off-by: Josh Romero <[email protected]>

---------

Signed-off-by: Josh Romero <[email protected]>
(cherry picked from commit 7efc231)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md
@opensearch-trigger-bot opensearch-trigger-bot bot requested a review from a team as a code owner March 27, 2023 17:22
Signed-off-by: Josh Romero <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Mar 27, 2023

Codecov Report

Merging #3697 (30d01f5) into 2.x (e3a5a2a) will not change coverage.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##              2.x    #3697   +/-   ##
=======================================
  Coverage   66.46%   66.46%           
=======================================
  Files        3209     3209           
  Lines       61610    61610           
  Branches     9505     9505           
=======================================
  Hits        40951    40951           
  Misses      18382    18382           
  Partials     2277     2277           
Flag Coverage Δ
Linux 66.41% <ø> (ø)
Windows 66.41% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@joshuarrrr joshuarrrr merged commit 6754c4d into 2.x Mar 28, 2023
@github-actions github-actions bot deleted the backport/backport-2720-to-2.x branch March 28, 2023 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants