fix(vis_type_vega): Use default categorical color palette directly

[joshuarrrr]

Description

rather than relying on vega.scheme. Also update vega.scheme name

Before

Screen.Recording.2023-03-27.at.6.37.17.PM.mov

After

(note that the color palette scale is still applied correctly)

Screen.Recording.2023-03-27.at.6.42.25.PM.mov

Possible Breaking Change

The only usage of the elastic custom scheme previously was to set the default value for config.range.category, and that behavior is restored by this PR. However, it was previously possible to explicitly set scheme: "elastic" within a spec - that's no longer possible. I think it's highly unlikely that there's a vega property that accepts a scheme property that doesn't also use the default config.range.category, but it may be possible. I'm also unsure if elastic ever documented any such usage. But my personal judgement is that this is unlikely to break any real user specs.

Issues Resolved

Fixes #3582

Check List

• All tests pass
  • yarn test:jest
  • yarn test:jest_integration
  • yarn test:ftr
• New functionality includes testing.
• New functionality has been documented.
• Update CHANGELOG.md
• Commits are signed per the DCO using --signoff

[codecov-commenter]

Codecov Report

Merging #3663 (217d6ad) into main (de06344) will not change coverage.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##             main    #3663   +/-   ##
=======================================
  Coverage   66.45%   66.45%           
=======================================
  Files        3208     3208           
  Lines       61593    61593           
  Branches     9502     9502           
=======================================
  Hits        40932    40932           
  Misses      18384    18384           
  Partials     2277     2277           

Flag	Coverage Δ
Linux	66.40% <100.00%> (ø)
Windows	66.40% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...ins/vis_type_vega/public/data_model/vega_parser.ts	80.67% <100.00%> (ø)
...s/vis_type_vega/public/vega_view/vega_base_view.js	56.09% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[abbyhu2000]

@joshuarrrr I think this is missing a changelog entry?

[joshuarrrr]

@abbyhu2000 Yeah, it also needs a regression test case.

[joshuarrrr]

I looked more deeply into this, and I can't really figure out what the root cause is. It appears this is a regression caused by bumping vega from 5.22.1 to 5.22.3: #3533

But none of the changes really jump out at me as a possible cause: https://github.com/vega/vega/releases/tag/v5.23.0

Using a reference to the elastic scheme still parses correctly from vega-lite to vega, but fails when executing the vega spec.

Given the above I'm not sure a regression test is particularly helpful in this case. While using the scheme would be nice, the fix here is probably more robust and just as good given our current vega implementation.

[joshuarrrr]

Changelog isn't necessary, as this is a minor re-implementation to fix an unreleased regression.

[ananzh]

I think the change seems to be beneficial for improved accessibility and error resolution. If the assessment is correct, the risks should be minimal. I also see tests been added which is good.