Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUILD] Update notice generator #350

Merged
merged 1 commit into from
May 13, 2021
Merged

[BUILD] Update notice generator #350

merged 1 commit into from
May 13, 2021

Conversation

kavilla
Copy link
Member

@kavilla kavilla commented May 12, 2021

Description

Update the notice generator so that builds come with the expected header

Signed-off-by: Kawika Avilla [email protected]

Issues Resolved

n/a

Check List

  • [] New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

@kavilla
[BUILD] Update notice generator
9e12693 
Update the notice generator so that builds come with the
expected header

Signed-off-by: Kawika Avilla <[email protected]>
@kavilla kavilla added the rename label May 12, 2021
@kavilla
Copy link
Member Author

kavilla commented May 12, 2021 •
edited
Loading

Results after running node scripts/build:

OpenSearch
Copyright 2021 OpenSearch Contributors

This product includes software developed by Elasticsearch (http://www.elastic.co).
Copyright 2009-2018 Elasticsearch

This product includes software developed by The Apache Software Foundation (http://www.apache.org/)

This product includes software developed by Joda.org (http://www.joda.org/).

@opensearch-ci-bot
Copy link
Collaborator

✅   DCO Check Passed 9e12693

tmarkley
tmarkley approved these changes May 12, 2021
View reviewed changes
Copy link
Contributor

@tmarkley tmarkley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

mihirsoni
mihirsoni approved these changes May 13, 2021
View reviewed changes
Copy link
Contributor

@mihirsoni mihirsoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !! Thanks for the changes.

@mihirsoni mihirsoni merged commit 439e67a into opensearch-project:main May 13, 2021
kavilla added a commit that referenced this pull request May 21, 2021
@kavilla
[BUILD] Update notice generator (#350)
1401331 
Update the notice generator so that builds come with the
expected header

Signed-off-by: Kawika Avilla <[email protected]>
@kavilla kavilla deleted the avillk/update_notice_generator branch May 24, 2021 06:54
@kavilla kavilla mentioned this pull request Aug 7, 2021
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ananzh ananzh ananzh approved these changes

@tmarkley tmarkley tmarkley approved these changes

@mihirsoni mihirsoni mihirsoni approved these changes

@boktorbb boktorbb Awaiting requested review from boktorbb

Assignees
No one assigned
Labels
rename
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kavilla @opensearch-ci-bot @mihirsoni @tmarkley @ananzh