Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x][Maintenance] Bumps re2 and supertest #3320

Merged
merged 1 commit into from
Jan 25, 2023

Conversation

ananzh
Copy link
Member

@ananzh ananzh commented Jan 25, 2023

Description

  • Removes manual resolution on qs. The latest version of supertest depends on v6.11.0.
  • Adds steps for upgrading re2.
  • Addresses CVE-2022-24999 (no issue opened)

Backport PR:

#3018

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
    • yarn test:ftr
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

* Removes manual resolution on `qs`. The latest version of `supertest` depends on v6.11.0.
* Adds steps for upgrading `re2`.
* Addresses CVE-2022-24999 (no issue opened)

Backport PR:
opensearch-project#3018

Signed-off-by: Tommy Markley <[email protected]>
@ananzh ananzh requested a review from a team as a code owner January 25, 2023 18:54
@codecov-commenter
Copy link

codecov-commenter commented Jan 25, 2023

Codecov Report

Merging #3320 (da552c5) into 2.x (da552c5) will not change coverage.
The diff coverage is n/a.

❗ Current head da552c5 differs from pull request most recent head 523ddcd. Consider uploading reports for the commit 523ddcd to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##              2.x    #3320   +/-   ##
=======================================
  Coverage   66.55%   66.55%           
=======================================
  Files        3203     3203           
  Lines       61327    61327           
  Branches     9452     9452           
=======================================
  Hits        40819    40819           
  Misses      18253    18253           
  Partials     2255     2255           
Flag Coverage Δ
Linux 66.50% <0.00%> (ø)
Windows 66.50% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@joshuarrrr joshuarrrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple questions, but not blocking

package.json Show resolved Hide resolved
yarn.lock Show resolved Hide resolved
@ananzh ananzh merged commit d06c0b3 into opensearch-project:2.x Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants