[Tests] Fix integration test due to code change in osd-plugin-helper #318
Conversation
|
✅ DCO Check Passed b5c3474 |
| @@ -94,8 +94,7 @@ it('builds a generated plugin into a viable archive', async () => { | |||
| ); | |||
|
|
|||
| expect(buildProc.all).toMatchInlineSnapshot(` | |||
| " warn These tools might work with 7.9 versions, but there are known workarounds required. See https://github.com/elastic/kibana/issues/82466 for more info | |||
There was a problem hiding this comment.
Are we sure that we want to remove this warning and link?
There was a problem hiding this comment.
In packages/osd-plugin-helpers/src/cli.ts we removed version check so there is no log warning 'These tools might work with 7.9 versions, but there are known workarounds required'. That is the reason this particular functional test failed. Thanks for checking.
There was a problem hiding this comment.
this should be auto updated with yarn run test:jest_integration -u
There was a problem hiding this comment.
Yes. yarn run test:jest_integration -u will generate same result by deleting that warning sentence. Mine also changed version 7.9.0 to 1.0.0, since we will change the versions eventually.
Signed-off-by: Anan Zhuang <[email protected]>
|
✅ DCO Check Passed 7b23765 |
…er (#318) Signed-off-by: Anan Zhuang <[email protected]> Co-authored-by: Ubuntu <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: Ubuntu [email protected]
Description
Due to code change in #312 on packages/osd-plugin-helpers/src/cli.ts , packages/osd-plugin-helpers/src/integration_tests/build.test.ts does not work. This PR fixed this particular integration test.
Issues Resolved
na
Check List