Update README.md with the nvm, yarn setup steps #317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ DCO Check Passed 4c99c9c |
ananzh
previously approved these changes
Apr 24, 2021
kavilla
previously approved these changes
Apr 26, 2021
|
Thanks for the reviews. Let me know if I need to rebase the branch. I can do it. |
This commit adds the installation steps of yarn and npm in the README.md file before the setup. Signed-off-by: Venu Vardhan Reddy Tekula <[email protected]>
|
Oops, I thought of rebasing the branch so that it is easy to merge but it seems all the approved reviews are reverted. 🙁 |
|
✅ DCO Check Passed e978294 |
kavilla
approved these changes
Apr 27, 2021
kavilla
pushed a commit
that referenced
this pull request
May 21, 2021
This commit adds the installation steps of yarn and npm in the README.md file before the setup. Signed-off-by: Venu Vardhan Reddy Tekula <[email protected]>
SuZhou-Joe
pushed a commit
to SuZhou-Joe/OpenSearch-Dashboards
that referenced
this pull request
Apr 7, 2024
* Add workspace overview page (#19) * feat: add workspace overview page Signed-off-by: Lin Wang <[email protected]> * refactor: move paths to common constants Signed-off-by: Lin Wang <[email protected]> * feat: add workspace overview item by custom nav in start phase Signed-off-by: Lin Wang <[email protected]> * refactor: change to currentWorkspace$ in workspace client Signed-off-by: Lin Wang <[email protected]> --------- Signed-off-by: Lin Wang <[email protected]> * restore yml Signed-off-by: Hailong Cui <[email protected]> --------- Signed-off-by: Lin Wang <[email protected]> Signed-off-by: Hailong Cui <[email protected]> Co-authored-by: Lin Wang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This commit adds the installation steps of yarn and npm in the README.md file before the setup.
Issues Resolved
Closes #270
Check List
@seraphjiang, do you have any suggestions?