Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.x] Add Windows CI to the GitHub workflow #2985

Merged
merged 1 commit into from
Dec 1, 2022
Merged

[Backport 2.x] Add Windows CI to the GitHub workflow #2985

merged 1 commit into from
Dec 1, 2022

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport f44ec7c from #2966.

@github-actions
Add Windows CI to the workflow (#2966)
6195d1e 
Signed-off-by: Miki <[email protected]>

Signed-off-by: Miki <[email protected]>
(cherry picked from commit f44ec7c)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md
@opensearch-trigger-bot opensearch-trigger-bot bot requested a review from a team as a code owner December 1, 2022 03:04
@AMoo-Miki AMoo-Miki added the autocut Skip the changelog verification check on backports label Dec 1, 2022
@codecov-commenter
Copy link

codecov-commenter commented Dec 1, 2022 •
edited
Loading

Codecov Report

Merging #2985 (6195d1e) into 2.x (01da0af) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              2.x    #2985   +/-   ##
=======================================
  Coverage   66.66%   66.67%           
=======================================
  Files        3219     3219           
  Lines       61448    61448           
  Branches     9417     9417           
=======================================
+ Hits        40967    40971    +4     
+ Misses      18234    18232    -2     
+ Partials     2247     2245    -2
Flag Coverage Δ
Windows 66.67% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/osd-opensearch/src/artifact.js 34.56% <0.00%> (-14.20%) ⬇️
src/dev/build/lib/config.ts 79.41% <0.00%> (ø)
src/dev/build/lib/get_build_number.ts 57.14% <0.00%> (ø)
...ic/application/models/sense_editor/sense_editor.ts 64.88% <0.00%> (+0.88%) ⬆️
...ges/osd-apm-config-loader/src/config.test.mocks.ts 100.00% <0.00%> (+8.69%) ⬆️
packages/osd-cross-platform/src/path.ts 82.92% <0.00%> (+31.70%) ⬆️
src/setup_node_env/harden/child_process.js 76.92% <0.00%> (+38.46%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@kavilla
Copy link
Member

kavilla commented Dec 1, 2022

Created an issue to utilize templates or matrices: #2991

kavilla
kavilla approved these changes Dec 1, 2022
View reviewed changes
Copy link
Member

@kavilla kavilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming test failures are expected due to PRs being broken apart.

@AMoo-Miki
Copy link
Collaborator

Assuming test failures are expected due to PRs being broken apart.

Yes. Thanks.

@AMoo-Miki AMoo-Miki merged commit 85b69e9 into 2.x Dec 1, 2022
@github-actions github-actions bot deleted the backport/backport-2966-to-2.x branch December 1, 2022 19:42
@manasvinibs manasvinibs added the v2.5.0 'Issues and PRs related to version v2.5.0' label Jan 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kavilla kavilla kavilla approved these changes

@AMoo-Miki AMoo-Miki AMoo-Miki approved these changes

Assignees
No one assigned
Labels
autocut Skip the changelog verification check on backports v2.5.0 'Issues and PRs related to version v2.5.0'
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@codecov-commenter @kavilla @AMoo-Miki @manasvinibs