Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 1.3][Manual] Bump prismjs to 1.29.0 to fix CVE-2022-23647 (#2668) #2952

Merged

Conversation

joshuarrrr
Copy link
Member

backport 8a4a5ba from #2668

…t#2668)

Signed-off-by: Zilong Xia <[email protected]>

Signed-off-by: Zilong Xia <[email protected]>
(cherry picked from commit 8a4a5ba)
abbyhu2000
abbyhu2000 previously approved these changes Nov 30, 2022
AMoo-Miki
AMoo-Miki previously approved these changes Nov 30, 2022
@joshuarrrr joshuarrrr dismissed stale reviews from AMoo-Miki and abbyhu2000 via c324098 November 30, 2022 18:52
Copy link
Contributor

@seanneumann seanneumann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than DCO check.

@joshuarrrr
Copy link
Member Author

Yeah, there's a bug in the DCO check when it runs for backports - somehow the DCO check gets the anonymized GH user email instead of the real one:

Commit sha: [2b96964](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/2952/commits/2b96964522b2411c747009e11fea29cddd2b67d2), Author: ZilongX, Committer: Josh Romero; Can not find "ZilongX [[email protected]](mailto:[email protected])", in ["Zilong Xia [[email protected]](mailto:[email protected])", "Zilong Xia [[email protected]](mailto:[email protected])"].

I plan to open an issue as part of the post-1.3.7 action items.

@joshuarrrr joshuarrrr merged commit ef79eba into opensearch-project:1.3 Nov 30, 2022
@joshuarrrr joshuarrrr deleted the backport/backport-2668-to-1.3 branch November 30, 2022 23:59
@ashwin-pc ashwin-pc changed the title [Backport - Manual] Bump prismjs to 1.29.0 to fix CVE-2022-23647 (#2668) [Backport 1.3][Manual] Bump prismjs to 1.29.0 to fix CVE-2022-23647 (#2668) Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants