-
Notifications
You must be signed in to change notification settings - Fork 916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change Version to 1.0.0 #292
Conversation
Signed-off-by: Mihir Soni <[email protected]>
✅ DCO Check Passed 7dbca0c |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Pulled it down all working fine with me! I see some exceptions on the service side but nothing blocking Dashboards from working from smoke tests.
start dco check |
✅ DCO Check Passed 7dbca0c |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally and it seems to be working fine. Looks good
Waiting for this PR to be merged opensearch-project/OpenSearch#555 |
@nknize feel free to let us know / merge this PR whenever you have merged OpenSearch PR |
will this work with migrating index-pattern? |
This commit rebases the versioning to OpenSearch-Dashboards 1.0.0 Signed-off-by: Mihir Soni <[email protected]>
Signed-off-by: Mihir Soni [email protected]
Description
[Describe what this change achieves] This change will reset the version of Dashboards to
1.0.0
. This will be going to main branch as of now more details on this opensearch-project/OpenSearch#95 (comment)Testing
In order to test this
./gradlew :distribution:archives:oss-linux-tar:assemble
Issues Resolved
[List any issues this PR will resolve] #226
Check List