Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor] Replace url parse format resolve with whatwg url #2910

Merged
Changes from 1 commit
Commits
Show all changes
53 commits
Select commit Hold shift + click to select a range
4a67aec
update test/server_integration/http/ssl_redirect/config.js Url to for…
wanglam Nov 7, 2022
c37c80d
update for examples/url_generators_examples/public/url_generator.ts
wanglam Nov 7, 2022
c2511a8
update packages/osd-dev-utils/src/osd_client/osd_client_requester.ts
wanglam Nov 7, 2022
2921fda
update src/cli_plugin/install/download.js
wanglam Nov 7, 2022
3247937
update packages/osd-test/src/failed_tests_reporter/github_api.ts
wanglam Nov 7, 2022
defe504
update packages/osd-test/src/functional_test_runner/lib/docker_server…
wanglam Nov 7, 2022
12cc53f
update src/cli/serve/serve.js
wanglam Nov 7, 2022
2218ede
update src/core/public/application/utils/parse_app_url.ts
wanglam Nov 7, 2022
3fc62a3
update src/core/public/chrome/chrome_service.tsx
wanglam Nov 7, 2022
d1cc130
update src/core/public/chrome/ui/header/header_logo.tsx
wanglam Nov 7, 2022
14b5497
update src/core/server/http/base_path_proxy_server.ts
wanglam Nov 7, 2022
a76fd60
update src/core/server/http/http_server.mocks.ts
wanglam Nov 7, 2022
592301b
update src/core/server/http/http_server.ts
wanglam Nov 7, 2022
5fabfd3
update src/core/server/http/https_redirect_server.ts
wanglam Nov 7, 2022
7c5e014
update src/core/server/opensearch/legacy/opensearch_client_config.ts
wanglam Nov 7, 2022
1517b5a
update src/plugins/console/server/lib/opensearch_proxy_config.ts
wanglam Nov 8, 2022
7248b3f
update src/plugins/console/server/lib/proxy_config.ts
wanglam Nov 8, 2022
fea59fe
update src/plugins/console/server/routes/api/console/proxy/create_han…
wanglam Nov 8, 2022
73a0cb4
update src/plugins/maps_legacy/public/map/service_settings.test.js
wanglam Nov 8, 2022
0a293d1
update src/plugins/share/public/lib/url_shortener.ts
wanglam Nov 8, 2022
7792efa
update test/plugin_functional/test_suites/application_links/redirect_…
wanglam Nov 8, 2022
652a81c
update getOpenSearchDashboardsUrl method in funtional tests
wanglam Nov 8, 2022
7b0a2fc
change config servers.opensearch and servers.opensearchDashboards to URL
wanglam Nov 8, 2022
90e29a1
update src/plugins/share/public/components/url_panel_content.tsx
wanglam Nov 10, 2022
9e8818c
update expected url due to parentheses and single quotation mark encoded
wanglam Nov 22, 2022
f683ba2
remove unnecessary imported URL
wanglam Dec 13, 2022
b53ee93
add force validate new URL create
wanglam Dec 13, 2022
c910dea
add changelog
wanglam Dec 13, 2022
3d84d50
Merge branch 'main' into refactor-replace-url-parse-format-resolve-wi…
joshuarrrr Dec 15, 2022
b73ac85
update to use object spread construct URLSearchParams
wanglam Dec 16, 2022
507c3a8
renaming getUrlParts to getURL
wanglam Dec 16, 2022
3bf1cad
Merge branch 'main' into refactor-replace-url-parse-format-resolve-wi…
wanglam Dec 20, 2022
f5a13f0
fix force url validate remove hash part
wanglam Dec 29, 2022
1731fc0
update opensearch config getUrlParts to getURL
wanglam Dec 29, 2022
2d007f0
remove search string compare in header_logo
wanglam Dec 30, 2022
c2feeb4
fix: url was truncated incorrectly
wanglam Jan 12, 2023
610ca30
feat: parse URL string port to number port
wanglam Jan 12, 2023
91c36b9
Revert "change config servers.opensearch and servers.opensearchDashbo…
wanglam Jan 28, 2023
a2d7108
feat: add fullURL to urlPartsSchema and use fullURL generate url string
wanglam Feb 9, 2023
32ec422
fix: change getURLParts to getUrlParts
wanglam Feb 9, 2023
3408cc5
Merge branch 'main' into refactor-replace-url-parse-format-resolve-wi…
wanglam Feb 9, 2023
27529b1
fix: url parts pass to getUrl.noAuth in test/functional/page_objects/…
wanglam Feb 9, 2023
803c96a
fix: colon suffix missed in protocol
wanglam Feb 10, 2023
63a8e87
fix: remove all slash suffix for fullURL toString
wanglam Feb 10, 2023
12d2e78
fix: slice(0, 1) cause invalid URL
wanglam Feb 10, 2023
4b061b3
Merge branch 'main' into refactor-replace-url-parse-format-resolve-wi…
wanglam Feb 10, 2023
ec8ce6a
fix: use pared protocol, hostname and port
wanglam Feb 10, 2023
d8ad24d
fix: clone new URL and modify username and password
wanglam Feb 10, 2023
c74698b
fix: slice(0 - 1) cause invalid opensearch host
wanglam Feb 10, 2023
9154295
Merge branch 'main' into refactor-replace-url-parse-format-resolve-wi…
wanglam Feb 13, 2023
6ebdd20
update src/core/public/chrome/ui/header/home_loader.tsx
wanglam Feb 14, 2023
3d93282
Merge branch 'main' into refactor-replace-url-parse-format-resolve-wi…
wanglam Mar 21, 2023
a846ba1
Add serverUrl property and refactor slice(0, -1) to it
wanglam Mar 21, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: slice(0, 1) cause invalid URL
Signed-off-by: Lin Wang <[email protected]>
  • Loading branch information
wanglam committed Feb 10, 2023

Unverified

No user is associated with the committer email.
commit 12d2e78eaa5298cb60f0ebf561209ce1687a065e
2 changes: 1 addition & 1 deletion test/common/services/opensearch_archiver.ts
Original file line number Diff line number Diff line change
@@ -57,7 +57,7 @@ export function OpenSearchArchiverProvider({
opensearchDashboardsUrl: config
.get('servers.opensearchDashboards.fullURL')
.toString()
.slice(0, 1),
.slice(0, -1),
});

if (hasService('opensearchDashboardsServer')) {