Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tests] ciGroup2 functional test fixes #291

Merged
merged 1 commit into from
Apr 15, 2021

Conversation

kavilla
Copy link
Member

@kavilla kavilla commented Apr 15, 2021

Description

This does not fix everything in group 2, there are still failures which I believe
are being caused by some data being imported but this fixes an error in the plugins
of a incomplete rename of applyOpenSearchResp.

node scripts/functional_tests.js --config test/functional/config.js --include ciGroup2

Signed-off-by: Kawika Avilla [email protected]

Issues Resolved

Partially #247

Check List

  • New functionality includes testing.
    • All tests pass (besides functional tests)
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

This does not fix everything in group 2, there are still failures which I believe
are being caused by some data being imported but this fixes an error in the plugins
of a incomplete rename of applyOpenSearchResp.

node scripts/functional_tests.js --config test/functional/config.js --include ciGroup2

Signed-off-by: Kawika Avilla <[email protected]>
@odfe-release-bot
Copy link

✅   DCO Check Passed 5908e93

Copy link
Contributor

@mihirsoni mihirsoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !!!
Do we have failures list ?

@peterzhuamazon
Copy link
Member

start dco check

@odfe-release-bot
Copy link

✅   DCO Check Passed 5908e93

Copy link
Contributor

@boktorbb boktorbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kavilla
Copy link
Member Author

kavilla commented Apr 15, 2021

LGTM !!!
Do we have failures list ?

Here are the tests I have failing locally: #247 (comment)

@kavilla kavilla merged commit bcfa288 into main Apr 15, 2021
@kavilla kavilla deleted the kavilla/update-func-test-ciGroup2 branch April 15, 2021 20:13
kavilla added a commit that referenced this pull request May 21, 2021
This does not fix everything in group 2, there are still failures which I believe
are being caused by some data being imported but this fixes an error in the plugins
of a incomplete rename of applyOpenSearchResp.

node scripts/functional_tests.js --config test/functional/config.js --include ciGroup2

Signed-off-by: Kawika Avilla <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants