-
Notifications
You must be signed in to change notification settings - Fork 916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump version on 2.x branch to 2.5.0 #2884
Conversation
Signed-off-by: Zelin Hao <[email protected]>
From OSS oncall: CI failed. can you check? If a re-run is needed and you don't have permission to trigger, let me know |
It usually means that 2.5 isn't ready but right there is a chicken and egg problem I guess because part of the 2.5 stuff is that they won't trigger an OpenSearch build until OpenSearch and OpenSearch Dashboards have been bumped. But the CI would depend on 2.5 OpenSearch snapshot being built. So historically we have just merged this version bumps with the CI failing. |
Codecov Report
@@ Coverage Diff @@
## 2.x #2884 +/- ##
=======================================
Coverage 66.67% 66.68%
=======================================
Files 3219 3219
Lines 61445 61445
Branches 9417 9417
=======================================
+ Hits 40968 40972 +4
+ Misses 18231 18228 -3
+ Partials 2246 2245 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Right. We won't be able to trigger the build for 2.5.0 until version gets incremented and I think without the build the bwc tests couldn't pass. We now only have the min artifacts for OpenSearch instead of Dashboards. So do I need to add anything to the CHANGELOG or you would take care of it? Thanks. @kavilla |
Signed-off-by: Zelin Hao [email protected]
Description
Bump version on 2.x branch to 2.5.0
Issues Resolved
Part of post release activities as we just launched the 2.4.0 release.
Check List
yarn test:jest
yarn test:jest_integration
yarn test:ftr