-
Notifications
You must be signed in to change notification settings - Fork 918
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Vis Builder] Removed Hard Coded Strings and Used i18n to translate #2867
[Vis Builder] Removed Hard Coded Strings and Used i18n to translate #2867
Conversation
Signed-off-by: AbhishekReddy1127 <[email protected]>
ab3daef
to
e6e52d7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ship it!
Codecov Report
@@ Coverage Diff @@
## main #2867 +/- ##
==========================================
- Coverage 66.67% 66.67% -0.01%
==========================================
Files 3219 3219
Lines 61445 61445
Branches 9417 9417
==========================================
- Hits 40970 40968 -2
- Misses 18229 18231 +2
Partials 2246 2246
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-2867-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 b19c1717a29fffa1b40f8073c6dfb3fb4fe85972
# Push it to GitHub
git push --set-upstream origin backport/backport-2867-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.x Then, create a pull request where the |
…pensearch-project#2867) Signed-off-by: AbhishekReddy1127 <[email protected]> Signed-off-by: AbhishekReddy1127 <[email protected]>
…pensearch-project#2867) Signed-off-by: AbhishekReddy1127 <[email protected]> Signed-off-by: AbhishekReddy1127 <[email protected]>
…pensearch-project#2867) Signed-off-by: AbhishekReddy1127 <[email protected]> Signed-off-by: AbhishekReddy1127 <[email protected]>
…pensearch-project#2867) Signed-off-by: AbhishekReddy1127 <[email protected]> Signed-off-by: AbhishekReddy1127 <[email protected]> Signed-off-by: Sergey Osipov <[email protected]>
…2867) Signed-off-by: AbhishekReddy1127 <[email protected]> Signed-off-by: AbhishekReddy1127 <[email protected]> (cherry picked from commit b19c171) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…2867) Signed-off-by: AbhishekReddy1127 <[email protected]> Signed-off-by: AbhishekReddy1127 <[email protected]> (cherry picked from commit b19c171) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…2867) (#3189) Signed-off-by: AbhishekReddy1127 <[email protected]> Signed-off-by: AbhishekReddy1127 <[email protected]> (cherry picked from commit b19c171) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Signed-off-by: AbhishekReddy1127 <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…pensearch-project#2867) Signed-off-by: AbhishekReddy1127 <[email protected]> Signed-off-by: AbhishekReddy1127 <[email protected]> Signed-off-by: Arpit Bandejiya <[email protected]>
…pensearch-project#2867) Signed-off-by: AbhishekReddy1127 <[email protected]> Signed-off-by: AbhishekReddy1127 <[email protected]> Signed-off-by: David Sinclair <[email protected]>
…pensearch-project#2867) Signed-off-by: AbhishekReddy1127 <[email protected]> Signed-off-by: AbhishekReddy1127 <[email protected]> Signed-off-by: David Sinclair <[email protected]>
Signed-off-by: AbhishekReddy1127 [email protected]
Description
Removed Hard Coded Strings and Used i18n to translate. As of now we cannot implement the Localization methods we had here due to the variables.
Issues Resolved
Partially resolves #958
Check List
yarn test:jest
yarn test:jest_integration
yarn test:ftr