-
Notifications
You must be signed in to change notification settings - Fork 916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds CHANGELOG.md and Release Notes for 2.4.0 #2809
Conversation
d053296
to
b8872ed
Compare
b8872ed
to
ff0d86f
Compare
ff0d86f
to
0d17964
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🥹
0d17964
to
8db9ca8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me go through a 2nd round.
8db9ca8
to
35c8dc3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let me go another round
- [CVE-2022-3517] Bump minimatch to 3.0.5 and [IBM X-Force ID: 220063] unset-value to 2.0.1 ([#2640](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/2640)) | ||
- [CVE-2022-37601] Bump loader-utils to 2.0.3 ([#2706](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/2706)) | ||
- [Legacy Maps] Prevent reverse-tabnabbing ([#2540](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/2540)) | ||
- [WS-2022-0284] [WS-2022-0280] Bump moment-timezone from 0.5.34 to 0.5.37 ([#2361](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/2361)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[WS-2022-0284] [WS-2022-0280] <-- no space between the two CVE
Then add a space --> [WS-2022-0280] Bump...
[WS-2022-0284][WS-2022-0280] Bump moment-timezone from 0.5.34 to 0.5.37
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why thumbs down?
CHANGELOG.md
Outdated
- [Multi DataSource] Make text content dynamically translated & update unit tests ([#2570](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/2570)) | ||
- [Multi DataSource] Support legacy client for data source ([#2204](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/2204)) | ||
- [Multi DataSource] UX enhacement on index pattern management stack ([#2505](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/2505)) | ||
- [Multi DataSource] UX enhancement for Data source management creation page ([#2051](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/2501)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for --> on
I see they all use on
, but only this one use for
- Fix JUnit Reporter test ([#1338](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/1338)) | ||
- Remove include_type_name from OpenSearch Archiver ([#1334](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/1334)) | ||
- Runs GitHub workflow unit tests in band ([#1306](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/1306)) | ||
- Upgrades jest to v27 ([#1301](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/1301)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Upgrade
- Fixes inconsistent plugin installation tests ([#1346](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/1346)) | ||
- Fix JUnit Reporter test ([#1338](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/1338)) | ||
- Remove include_type_name from OpenSearch Archiver ([#1334](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/1334)) | ||
- Runs GitHub workflow unit tests in band ([#1306](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/1306)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Run
- [BWC][CI] Handle distributions with qualifiers ([#1469](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/1469)) | ||
- BWC test improvements ([#1447](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/1447)) | ||
- [CI] bumps chromedriver to v100 ([#1410](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/1410)) | ||
- Fixes inconsistent plugin installation tests ([#1346](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/1346)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix
- [BWC][CI] Use ODFE 1.0.2 ([#1470](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/1470)) | ||
- [BWC][CI] Handle distributions with qualifiers ([#1469](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/1469)) | ||
- BWC test improvements ([#1447](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/1447)) | ||
- [CI] bumps chromedriver to v100 ([#1410](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/1410)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bump
- [BWC][CI] Update performance analzyer location ([#1474](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/1474)) | ||
- [BWC][CI] Use ODFE 1.0.2 ([#1470](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/1470)) | ||
- [BWC][CI] Handle distributions with qualifiers ([#1469](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/1469)) | ||
- BWC test improvements ([#1447](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/1447)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Backwards compatibility
|
||
### 🪛 Refactoring | ||
|
||
- Fixes interfaced errors across Dashboards ([#1409](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/1409)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix
|
||
### 🛠 Maintenance | ||
|
||
* Increment from 2.3 to 2.4. ([#2295](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/2295)) | ||
* Adding @zengyan-amazon as maintainer. | ||
- Runs functional test jobs in parallel w/ build job ([#1336](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/1356)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Run
* Increment from 2.3 to 2.4. ([#2295](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/2295)) | ||
* Adding @zengyan-amazon as maintainer. | ||
- Runs functional test jobs in parallel w/ build job ([#1336](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/1356)) | ||
- Removes unnecessary manual resolutions ([#1300](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/1300)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove
* Adding @zengyan-amazon as maintainer. | ||
- Runs functional test jobs in parallel w/ build job ([#1336](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/1356)) | ||
- Removes unnecessary manual resolutions ([#1300](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/1300)) | ||
- Removes backport and release-notes scripts ([#1234](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/1234)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove
- Runs functional test jobs in parallel w/ build job ([#1336](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/1356)) | ||
- Removes unnecessary manual resolutions ([#1300](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/1300)) | ||
- Removes backport and release-notes scripts ([#1234](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/1234)) | ||
- Removes storybook package and related code ([#1172](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/1172)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove
* README.md for dataSource and dataSourceManagement Plugin ([#2448](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/2448)) | ||
* Updates functionl testing information in Testing.md ([#2492](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/2492)) | ||
- [Admin] Add current maintainers as of 04/2022 ([#1426](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/1426)) | ||
- Exposes testing readme at the root level ([#1420](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/1420)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Expose
* Updating WS scans to ignore BWC artifacts in `cypress` ([#2408](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/2408)) | ||
* [CI] Run functional test repo as workflow ([#2503](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/2503)) | ||
- [Plugins] Fix default path to plugins ([#1468](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/1468)) | ||
- Reverts re2 back to 1.15.4 from 1.17.4 to fix build issues ([1419](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/1419)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Revert
- Update re2 for linux, darwin, and windows ([#1453](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/1453)) | ||
- Fixes tooltip when split series charts are used ([#1324](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/1324)) | ||
- Fixes the header's nav trigger button not closing the nav ([#1394](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/1394)) | ||
- Fixes the linting rules to accept only the approved copyright headers ([#1373](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/1373)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix
- Update re2 build for arm under node 14 ([#1454](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/1454)) | ||
- Update re2 for linux, darwin, and windows ([#1453](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/1453)) | ||
- Fixes tooltip when split series charts are used ([#1324](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/1324)) | ||
- Fixes the header's nav trigger button not closing the nav ([#1394](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/1394)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix
- [Bug] Fix copy as curl ([#1472](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/1472)) | ||
- Update re2 build for arm under node 14 ([#1454](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/1454)) | ||
- Update re2 for linux, darwin, and windows ([#1453](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/1453)) | ||
- Fixes tooltip when split series charts are used ([#1324](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/1324)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix
|
||
### 🐛 Bug Fixes | ||
|
||
- Removes irrelevant upsell in the timeout message ([#1599](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/1599)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove
|
||
#### Deprecations | ||
|
||
- Deprecates non-inclusive config names ([#1467](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/1467)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deprecate
#### Deprecations | ||
|
||
- Deprecates non-inclusive config names ([#1467](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/1467)) | ||
- Removes UI Framework KUI doc site ([#1379](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/1379)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove
|
||
|
||
### 🛡 Security | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A lot of inconsistencies here
Bumps, Bump Resolves
I only reviewed CHANGELOG since release note is just a copy of that. Don't forget to update that as well hhhh |
e93f03f
to
4ecb546
Compare
Updated that too. I Changed only 2.4.0 section of the CHANGELOG as the previous ones are already released and I don't think we should modify them post-release. |
Signed-off-by: Miki <[email protected]>
4ecb546
to
2d665aa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I add a bit more comments
Signed-off-by: Miki [email protected]
Check List
yarn test:jest
yarn test:jest_integration
yarn test:ftr