Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.x] Change wizard to vis_builder in file names and paths (#2587) #2687

Closed
wants to merge 1 commit into from
Closed

[Backport 2.x] Change wizard to vis_builder in file names and paths (#2587) #2687

wants to merge 1 commit into from

Conversation

abbyhu2000
Copy link
Member

Change all wizard reference in file names and paths to vis_builder

Signed-off-by: abbyhu2000 [email protected]

Signed-off-by: abbyhu2000 [email protected]
(cherry picked from commit f29f734)

Description

[Describe what this change achieves]

Issues Resolved

[List any issues this PR will resolve]

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
    • yarn test:ftr
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@abbyhu2000 abbyhu2000 marked this pull request as ready for review October 28, 2022 16:48
@abbyhu2000 abbyhu2000 requested a review from a team as a code owner October 28, 2022 16:48
joshuarrrr
joshuarrrr previously approved these changes Oct 28, 2022
View reviewed changes
ashwin-pc
ashwin-pc previously approved these changes Oct 28, 2022
View reviewed changes
@abbyhu2000 abbyhu2000 requested a review from joshuarrrr October 28, 2022 18:32
@joshuarrrr
Copy link
Member

@abbyhu2000 I think this is missing the CHANGELOG.md change? If you fixed a merge conflict, maybe it didn't get added to this commit.

@manasvinibs
Copy link
Member

@abbyhu2000 Do you want to update change log file?

@abbyhu2000
Copy link
Member Author

For some reason, the changelog already have information for this PR. https://github.com/opensearch-project/OpenSearch-Dashboards/blob/2.x/CHANGELOG.md

Maybe the previous backport PR already added it? @joshuarrrr @manasvinibs

@manasvinibs
Copy link
Member

manasvinibs commented Oct 28, 2022 •
edited
Loading

For some reason, the changelog already have information for this PR. https://github.com/opensearch-project/OpenSearch-Dashboards/blob/2.x/CHANGELOG.md

Maybe the previous backport PR already added it? @joshuarrrr @manasvinibs

I think it got added here in this PR b17f5c4 I think might have happened while resolving conflicts manually while merging the above changes in as main already has this changes.

manasvinibs
manasvinibs previously approved these changes Oct 28, 2022
View reviewed changes
@joshuarrrr
Copy link
Member

@abbyhu2000 Looks like there are a couple unit test failures (and unit tests that still reference wizard...)

@abbyhu2000
Copy link
Member Author

abbyhu2000 commented Oct 28, 2022 •
edited
Loading

@abbyhu2000 Looks like there are a couple unit test failures (and unit tests that still reference wizard...)

The unit test references to wizard are updated in the later PR. The unit tests fail here because a previous PR needs to be backported first. Will backport that PR right now. @joshuarrrr

@abbyhu2000 abbyhu2000 added the v2.4.0 'Issues and PRs related to version v2.4.0' label Oct 28, 2022
kavilla
kavilla previously approved these changes Oct 29, 2022
View reviewed changes
Copy link
Member

@kavilla kavilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm i think we can handle conflicts in github.

@abbyhu2000 abbyhu2000 dismissed stale reviews from kavilla, manasvinibs, and ashwin-pc via 4456321 October 31, 2022 17:31
@abbyhu2000 abbyhu2000 force-pushed the backport/backport-2587-to-2.x branch 3 times, most recently from fd7a97f to 0e4164d Compare October 31, 2022 23:51
@abbyhu2000
Change wizard to vis_builder in file names and paths (opensearch-proj…
999f432 
…ect#2587)

Change all wizard reference in file names and paths to vis_builder

Signed-off-by: abbyhu2000 <[email protected]>

Signed-off-by: abbyhu2000 <[email protected]>
(cherry picked from commit f29f734)
@abbyhu2000 abbyhu2000 force-pushed the backport/backport-2587-to-2.x branch from 0e4164d to 999f432 Compare November 1, 2022 18:23
@AMoo-Miki
Copy link
Collaborator

Closing in favor of #2719

@AMoo-Miki AMoo-Miki closed this Nov 2, 2022
@AMoo-Miki AMoo-Miki removed the v2.4.0 'Issues and PRs related to version v2.4.0' label Nov 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manasvinibs manasvinibs manasvinibs left review comments

@ashwin-pc ashwin-pc ashwin-pc left review comments

@kavilla kavilla kavilla left review comments

@joshuarrrr joshuarrrr Awaiting requested review from joshuarrrr joshuarrrr is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@abbyhu2000 @joshuarrrr @manasvinibs @AMoo-Miki @kavilla @ashwin-pc