Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates related to functional tests #260

Merged
merged 2 commits into from
Apr 9, 2021
Merged

Updates related to functional tests #260

merged 2 commits into from
Apr 9, 2021

Conversation

kavilla
Copy link
Member

@kavilla kavilla commented Apr 9, 2021

Description

This does not get the functional tests fully successful. These have changes that would be nice to go into the main branch before cut off.

Issues Resolved

#247 (not fully resolved yet)

Check List

  • New functionality includes testing.
    • All tests pass (except functional tests)
  • [ ] New functionality has been documented.
    • [ ] New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

kavilla added 2 commits April 9, 2021 17:49
@kavilla
[Tests] update management id
8e9acbb 
From opensearchDashboards to opensearch-dashboards.

Signed-off-by: Kawika Avilla <[email protected]>
@kavilla
[Tests] update opensearch_archiver
dd28ef2 
Signed-off-by: Kawika Avilla <[email protected]>
@kavilla kavilla requested review from mihirsoni, boktorbb and ananzh April 9, 2021 18:18
@odfe-release-bot
Copy link

✅   DCO Check Passed dd28ef2

mihirsoni
mihirsoni approved these changes Apr 9, 2021
View reviewed changes
Copy link
Contributor

@mihirsoni mihirsoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !!

Any reasoning why these files were added now and removed earlier ?

boktorbb
boktorbb approved these changes Apr 9, 2021
View reviewed changes
Copy link
Contributor

@boktorbb boktorbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mihirsoni mihirsoni merged commit 138bde1 into opensearch-project:main Apr 9, 2021
@kavilla kavilla mentioned this pull request Apr 24, 2021
Merged
5 tasks
@kavilla kavilla deleted the update-func-test-pre branch April 27, 2021 20:57
SuZhou-Joe added a commit to SuZhou-Joe/OpenSearch-Dashboards that referenced this pull request Feb 29, 2024
@SuZhou-Joe
Fix existing failed integration test cases (opensearch-project#260)
587f0d4 
* fix: integration test fail

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: change variable name

Signed-off-by: SuZhou-Joe <[email protected]>

---------

Signed-off-by: SuZhou-Joe <[email protected]>
@ruanyl ruanyl mentioned this pull request Apr 12, 2024
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ananzh ananzh ananzh approved these changes

@boktorbb boktorbb boktorbb approved these changes

@mihirsoni mihirsoni mihirsoni approved these changes

Assignees
No one assigned
Labels
test:functional
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kavilla @odfe-release-bot @mihirsoni @boktorbb @ananzh