[Table Visualization][BUG] remove local column width state #2582

ananzh · 2022-10-17T16:05:56Z

Description

remove local col width state to allow split tables to fetch updated col width state
fix type errors in usePagination

Partially resolved:

#2579 (comment)

Now col width state is sharing to all split tables in row/col

joshuarrrr

A couple minor questions

joshuarrrr · 2022-10-19T21:02:04Z

src/plugins/vis_type_table/public/components/table_vis_component.tsx

      handlers.uiState.set('vis.columnsWidth', nextState);
+      handlers.uiState?.emit('reload');


Do we need some error handling for the case that handlers.uiState?.emit is undefined? Maybe it's something we want to fail earlier on or else wait for?

I will remove the question mark and open a follow-up issue for error handling.

I update and add an item in the overall follow-up issue: #2551 and a separate issue here #2651

src/plugins/vis_type_table/public/types.ts

src/plugins/vis_type_table/public/utils/use_pagination.ts

* remove local col width state to allow split tables to fetch updated col width state * fix type errors in usePagination Partially resolved: opensearch-project#2579 (comment) Signed-off-by: Anan Zhuang <[email protected]>

…opensearch-project#2279) To convert the table visualization into React & OUI DataGrid component, in this PR, we did two main things: * clean out legacy angular code * restore table vis in react * Datagrid component does not support splitted grids. For future transfer to OUI Datagrid, we create a tableGroup in visData for splitted grids. issue resolved: opensearch-project#2212 https://github.com/opensearch-project/OpenSearch-Dashboards/issues/2213a Signed-off-by: Anan Zhuang <[email protected]> rename visTable back to opensearch_dashboards_table and add stronger type Signed-off-by: Anan Zhuang <[email protected]> Signed-off-by: Anan Zhuang <[email protected]> [Table Visualization] add a plain datagrid component (opensearch-project#2390) implement a plain OuiDataGrid component use the basic pagenation, sort and format. Partially resolve: opensearch-project#2305 Signed-off-by: Anan Zhuang <[email protected]> Signed-off-by: Anan Zhuang <[email protected]> [Table Visualization] restore datagrid columns (opensearch-project#2411) * restore datagrid columns * display column title correctly * deangular and re-use formatted column * convert formatted column to data grid column * restore filter in and filter out value functions Partially resolve: opensearch-project#2305 Signed-off-by: Anan Zhuang <[email protected]> [Table Visualization] restore pagination to table vis (opensearch-project#2461) * add pagination patically resolved: opensearch-project#2305 Signed-off-by: Anan Zhuang <[email protected]> [Table Visualization] make table vis column resizable (opensearch-project#2464) * add resizable state to column Partially resolve: opensearch-project#2305 Signed-off-by: Anan Zhuang <[email protected]> [Table Visualization] make table vis column sortable (opensearch-project#2502) * add sort state (asc | desc) to column * fix pagination issue Partially resolve: opensearch-project#2305 Signed-off-by: Anan Zhuang <[email protected]> [Table Visualization] format table cell and restore showTotal feature (opensearch-project#2562) * format table cell to show Date and percent * restore showTotal feature: it allows table vis to show total, avg, min, max and count statics on count * fix some type errors Partically resolved: opensearch-project#2379 Signed-off-by: Anan Zhuang <[email protected]> [Table Visualization]restore export csv feature to table vis (opensearch-project#2568) * add addtional action in toolbar to allow export data to csv. there are two types of csv, raw and formatted. raw is the original data and formatted is to show formatted Date and percentage data when needed. * when table is not saved, export csv file will be named as unsaved-raw.csv if choose raw. when table is saved with a filename, it will be saved as [filename]-[raw/formatted].csv Partically resolved: opensearch-project#2379 Signed-off-by: Anan Zhuang <[email protected]> [Table Visualization] split table in rows and columns (opensearch-project#2578) This PR implement a group component TableVisGroupComponent utilizing TableVisComponent as sub component. It also adds a title to TableVisComponent. Partically resolved: opensearch-project#2379 Signed-off-by: Anan Zhuang <[email protected]> [Table Visualization][IMPROVE] remove repeated column from split tables (opensearch-project#2583) Currently, when we split table by columns, the split column is shown both in the table title and as a separate column. This is not needed. In this PR, we remove the repeated column in split tables in col. Partically resolved: opensearch-project#2579 (comment) Signed-off-by: Anan Zhuang <[email protected]> [Table Visualization][BUG] remove local column width state (opensearch-project#2582) * remove local col width state to allow split tables to fetch updated col width state * fix type errors in usePagination Partially resolved: opensearch-project#2579 (comment) Signed-off-by: Anan Zhuang <[email protected]> Signed-off-by: Anan Zhuang <[email protected]> [Table Visualization][BUG] partical rows shows metrics for all columns (opensearch-project#2648) Currently, when we enable Show partial rows in the Options panel, we see metrics been added to every column even though Show metrics for every bucket/level is not enabled. Metrics are added and returned when we enable the partial rows. This PR fixed the bug by slice the returned data to allow only the last set of metrices. Partially resolved: opensearch-project#2579 (comment) Signed-off-by: Anan Zhuang <[email protected]>

To convert the table visualization into React & OUI DataGrid component, in this PR, we did two main things: * add an experimental table visualization * enable it in vis builder The experimental table vis has all the features from current table. It does couple of things: * restore table vis in react using OUI datagrid component * datagrid component does not support splitted grids. For future transfer to OUI Datagrid, we create a tableGroup in visData for splitted grids. * restore basic pagenation, sort and format. * implement datagrid columns * display column title correctly * deangular and re-use formatted column * convert formatted column to data grid column * restore filter in and filter out value functions * make table vis column resizable * format table cell to show Date and percent * restore showTotal feature: it allows table vis to show total, avg, min, max and count statics on count * restore export csv feature to table vis * split table in rows and columns Issue Resolved: opensearch-project#2212 opensearch-project#2213 opensearch-project#2305 opensearch-project#2379 [Table Visualization][IMPROVE] remove repeated column from split tables (opensearch-project#2583) Currently, when we split table by columns, the split column is shown both in the table title and as a separate column. This is not needed. In this PR, we remove the repeated column in split tables in col. Partically resolved: opensearch-project#2579 (comment) Signed-off-by: Anan Zhuang <[email protected]> [Table Visualization][BUG] remove local column width state (opensearch-project#2582) * remove local col width state to allow split tables to fetch updated col width state * fix type errors in usePagination Partially resolved: opensearch-project#2579 (comment) Signed-off-by: Anan Zhuang <[email protected]> Signed-off-by: Anan Zhuang <[email protected]> [Table Visualization][BUG] partical rows shows metrics for all columns (opensearch-project#2648) Currently, when we enable Show partial rows in the Options panel, we see metrics been added to every column even though Show metrics for every bucket/level is not enabled. Metrics are added and returned when we enable the partial rows. This PR fixed the bug by slice the returned data to allow only the last set of metrices. Partially resolved: opensearch-project#2579 (comment) Signed-off-by: Anan Zhuang <[email protected]>

ananzh requested a review from a team as a code owner October 17, 2022 16:05

ananzh self-assigned this Oct 17, 2022

ananzh requested review from joshuarrrr and ashwin-pc October 17, 2022 16:06

ananzh added the tableVis table visualization label Oct 17, 2022

ananzh force-pushed the feature/remove-local-width branch from c06e09e to 845fef2 Compare October 17, 2022 16:07

ananzh mentioned this pull request Oct 17, 2022

[Table Visualization] manual tests on new Table Vis features and track bug fix #2579

Closed

joshuarrrr reviewed Oct 19, 2022

View reviewed changes

[Table Visualization][BUG] remove local column width state

713d8fb

* remove local col width state to allow split tables to fetch updated col width state * fix type errors in usePagination Partially resolved: opensearch-project#2579 (comment) Signed-off-by: Anan Zhuang <[email protected]>

ananzh force-pushed the feature/remove-local-width branch from 845fef2 to 713d8fb Compare October 22, 2022 00:32

ananzh merged commit 5aac0d8 into opensearch-project:feature/tableVis Oct 22, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Table Visualization][BUG] remove local column width state #2582

[Table Visualization][BUG] remove local column width state #2582

ananzh commented Oct 17, 2022

joshuarrrr left a comment

joshuarrrr Oct 19, 2022

ananzh Oct 22, 2022

ananzh Oct 22, 2022 •

edited

Loading

		handlers.uiState.set('vis.columnsWidth', nextState);
		handlers.uiState?.emit('reload');

[Table Visualization][BUG] remove local column width state #2582

[Table Visualization][BUG] remove local column width state #2582

Conversation

ananzh commented Oct 17, 2022

Description

Partially resolved:

joshuarrrr left a comment

Choose a reason for hiding this comment

joshuarrrr Oct 19, 2022

Choose a reason for hiding this comment

ananzh Oct 22, 2022

Choose a reason for hiding this comment

ananzh Oct 22, 2022 • edited Loading

Choose a reason for hiding this comment

ananzh Oct 22, 2022 •

edited

Loading