[MD] skip data source view when pick default #2574

kristenTian · 2022-10-14T17:46:17Z

Signed-off-by: Kristen Tian [email protected]

Description

Skip data source view when pick default - When OSD enable data source feature, user can still choose to use default cluster, in this case, index pattern creation should render with previous experience for this phase.

Check List

codecov-commenter · 2022-10-14T18:34:02Z

Codecov Report

Merging #2574 (a4be06c) into main (115105a) will increase coverage by 0.00%.
The diff coverage is 0.00%.

❗ Current head a4be06c differs from pull request most recent head 29881d1. Consider uploading reports for the commit 29881d1 to get more accurate results

@@           Coverage Diff           @@
##             main    #2574   +/-   ##
=======================================
  Coverage   66.81%   66.81%           
=======================================
  Files        3207     3207           
  Lines       61136    61136           
  Branches     9313     9313           
=======================================
+ Hits        40845    40849    +4     
+ Misses      18059    18056    -3     
+ Partials     2232     2231    -1

Impacted Files	Coverage Δ
...ts/step_index_pattern/components/header/header.tsx	`63.63% <0.00%> (ø)`
packages/osd-optimizer/src/node/cache.ts	`52.77% <0.00%> (+2.77%)`	⬆️
...s/osd-optimizer/src/node/node_auto_tranpilation.ts	`87.75% <0.00%> (+4.08%)`	⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

zhongnansu

Please update PR description. Add the issues you resolved. For UI changes, better to have screenshots/gif/videos attached

zhongnansu · 2022-10-14T19:37:49Z

CHANGELOG.md

@@ -22,6 +22,7 @@ Inspired from [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
 * [Multi DataSource] Add experimental callout for index pattern section ([#2523](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/2523))
 * [Multi DataSource] Add data source config to opensearch-dashboards-docker ([#2557](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/2557))
 * [Multi DataSource] Make text content dynamically translated & update unit tests ([#2570](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/2570))
+* [Multi DataSource] Skip data source view in index pattern step when pick default ([#2574](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/2574))


I think this should be a bug fix, can you add to the bug section?

I am open to that, but not sure what should be categorized as bug fix, given this feature has not been released.

zhongnansu · 2022-10-14T19:42:51Z

...nents/create_index_pattern_wizard/components/step_index_pattern/components/header/header.tsx

@@ -103,14 +103,14 @@ export const Header: React.FC<HeaderProps> = ({
      <EuiFlexGroup>
        <EuiFlexItem>
          <EuiForm isInvalid={isInputInvalid}>
-            {dataSourceEnabled
+            {dataSourceEnabled && dataSourceRef?.title


why can't we only check if the dataSourceRef is defined, instead of using title. Is there a case that dataSouceRef comes without title?

Not today, but not sure in future, that's why I prefer to do the safer check -- also the UX only uses the title section and it does not make sense to show data source when it's not presented.

kristenTian · 2022-10-14T20:31:37Z

Please update PR description. Add the issues you resolved. For UI changes, better to have screenshots/gif/videos attached

There are no UX and issue related to this. Is the process require we have to create an issue every time we submit a PR?

zhongnansu · 2022-10-14T20:39:39Z

Please update PR description. Add the issues you resolved. For UI changes, better to have screenshots/gif/videos attached

There are no UX and issue related to this. Is the process require we have to create an issue every time we submit a PR?

You can create one if not exists. Yes, it's required. Only exception might be spelling error. See https://github.com/opensearch-project/OpenSearch-Dashboards/blob/main/CONTRIBUTING.md#first-things-first

kristenTian · 2022-10-14T20:45:04Z

Please update PR description. Add the issues you resolved. For UI changes, better to have screenshots/gif/videos attached

There are no UX and issue related to this. Is the process require we have to create an issue every time we submit a PR?

You can create one if not exists. Yes, it's required. Only exception might be spelling error. See https://github.com/opensearch-project/OpenSearch-Dashboards/blob/main/CONTRIBUTING.md#first-things-first

Thanks, "If it's truly a trivial change (e.g. spelling error), you can skip this step " I think this pr categorize as a trivial change lol

Signed-off-by: Kristen Tian <[email protected]>

zhongnansu · 2022-10-14T20:53:39Z

Please update PR description. Add the issues you resolved. For UI changes, better to have screenshots/gif/videos attached

There are no UX and issue related to this. Is the process require we have to create an issue every time we submit a PR?

You can create one if not exists. Yes, it's required. Only exception might be spelling error. See https://github.com/opensearch-project/OpenSearch-Dashboards/blob/main/CONTRIBUTING.md#first-things-first

Thanks, "If it's truly a trivial change (e.g. spelling error), you can skip this step " I think this pr categorize as a trivial change lol

I am holding my opinion on if this is a trivial change. Since the code will change the user experience from what's current in main. I feel like if the code change is to logic, no matter how small it is, shouldn't be considered as trivial. Love to see other maintainers input.

Signed-off-by: Kristen Tian <[email protected]> Signed-off-by: Kristen Tian <[email protected]> (cherry picked from commit 66f07c3)

kristenTian · 2022-10-14T21:21:07Z

Please update PR description. Add the issues you resolved. For UI changes, better to have screenshots/gif/videos attached

There are no UX and issue related to this. Is the process require we have to create an issue every time we submit a PR?

You can create one if not exists. Yes, it's required. Only exception might be spelling error. See https://github.com/opensearch-project/OpenSearch-Dashboards/blob/main/CONTRIBUTING.md#first-things-first

Thanks, "If it's truly a trivial change (e.g. spelling error), you can skip this step " I think this pr categorize as a trivial change lol

I am holding my opinion on if this is a trivial change. Since the code will change the user experience from what's current in main. I feel like if the code change is to logic, no matter how small it is, shouldn't be considered as trivial. Love to see other maintainers input.

This PR does not change any user experience or logic, it is only a one line tweak so that the previous commit can function as expected. -- which has issues already created and linked from UX. -- Speaking of which, I could link here: opensearch-project/ux#42

Signed-off-by: Kristen Tian <[email protected]> Signed-off-by: Kristen Tian <[email protected]> (cherry picked from commit 66f07c3) Co-authored-by: Kristen Tian <[email protected]>

Signed-off-by: Kristen Tian <[email protected]> Signed-off-by: Kristen Tian <[email protected]> Signed-off-by: Sergey V. Osipov <[email protected]>

kristenTian requested a review from a team as a code owner October 14, 2022 17:46

kristenTian force-pushed the OSD-main branch from a4be06c to 29881d1 Compare October 14, 2022 17:50

kristenTian added multiple datasource multiple datasource project backport 2.x labels Oct 14, 2022

kristenTian requested review from kavilla, joshuarrrr, ashwin-pc and zengyan-amazon October 14, 2022 18:22

zhongnansu reviewed Oct 14, 2022

View reviewed changes

[MD] skip data source view when pick default

8331a7f

Signed-off-by: Kristen Tian <[email protected]>

kristenTian force-pushed the OSD-main branch from fd59aa5 to 8331a7f Compare October 14, 2022 20:45

AMoo-Miki approved these changes Oct 14, 2022

View reviewed changes

zengyan-amazon approved these changes Oct 14, 2022

View reviewed changes

kristenTian merged commit 66f07c3 into opensearch-project:main Oct 14, 2022

opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 14, 2022

[MD] skip data source view when pick default (#2574)

33e06ee

Signed-off-by: Kristen Tian <[email protected]> Signed-off-by: Kristen Tian <[email protected]> (cherry picked from commit 66f07c3)

opensearch-trigger-bot bot mentioned this pull request Oct 14, 2022

[Backport 2.x] [MD] skip data source view when pick default #2577

Merged

AMoo-Miki added bug Something isn't working v2.4.0 'Issues and PRs related to version v2.4.0' labels Nov 5, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[MD] skip data source view when pick default #2574

[MD] skip data source view when pick default #2574

kristenTian commented Oct 14, 2022 •

edited

Loading

codecov-commenter commented Oct 14, 2022

zhongnansu left a comment

zhongnansu Oct 14, 2022

kristenTian Oct 14, 2022

zhongnansu Oct 14, 2022

kristenTian Oct 14, 2022

kristenTian commented Oct 14, 2022

zhongnansu commented Oct 14, 2022

kristenTian commented Oct 14, 2022

zhongnansu commented Oct 14, 2022

kristenTian commented Oct 14, 2022 •

edited

Loading

[MD] skip data source view when pick default #2574

[MD] skip data source view when pick default #2574

Conversation

kristenTian commented Oct 14, 2022 • edited Loading

Description

Check List

codecov-commenter commented Oct 14, 2022

Codecov Report

zhongnansu left a comment

Choose a reason for hiding this comment

zhongnansu Oct 14, 2022

Choose a reason for hiding this comment

kristenTian Oct 14, 2022

Choose a reason for hiding this comment

zhongnansu Oct 14, 2022

Choose a reason for hiding this comment

kristenTian Oct 14, 2022

Choose a reason for hiding this comment

kristenTian commented Oct 14, 2022

zhongnansu commented Oct 14, 2022

kristenTian commented Oct 14, 2022

zhongnansu commented Oct 14, 2022

kristenTian commented Oct 14, 2022 • edited Loading

kristenTian commented Oct 14, 2022 •

edited

Loading

kristenTian commented Oct 14, 2022 •

edited

Loading