[Backport 2.x] [MD]Add data source config to opensearch-dashboards-docker #2563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
Signed-off-by: Kristen Tian <[email protected]> Signed-off-by: Kristen Tian <[email protected]> (cherry picked from commit 8e8b89b)
kristenTian
approved these changes
Oct 12, 2022
Codecov Report
@@ Coverage Diff @@
## 2.x #2563 +/- ##
=======================================
Coverage 66.71% 66.71%
=======================================
Files 3204 3204
Lines 60964 60964
Branches 9267 9267
=======================================
Hits 40673 40673
Misses 18073 18073
Partials 2218 2218 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
Nice @kristenTian, Do we have a follow-up to add it the same: https://github.com/opensearch-project/opensearch-build/blob/main/docker/release/config/opensearch-dashboards/opensearch-dashboards-docker-entrypoint.sh#L156 I know this is duplicated and we should fix this in the build repo to pull from our versioned docker stuff. |
kavilla
approved these changes
Oct 13, 2022
kristenTian
added a commit
to kristenTian/opensearch-build
that referenced
this pull request
Oct 18, 2022
Related PR: opensearch-project/OpenSearch-Dashboards#2563 Signed-off-by: Kristen Tian <[email protected]>
kristenTian
added a commit
to kristenTian/opensearch-build
that referenced
this pull request
Nov 1, 2022
Related PR: opensearch-project/OpenSearch-Dashboards#2563 Signed-off-by: Kristen Tian <[email protected]>
peterzhuamazon
pushed a commit
to opensearch-project/opensearch-build
that referenced
this pull request
Nov 1, 2022
Related PR: opensearch-project/OpenSearch-Dashboards#2563 Signed-off-by: Kristen Tian <[email protected]> Signed-off-by: Kristen Tian <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 8e8b89b from #2557