-
Notifications
You must be signed in to change notification settings - Fork 919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sample config of multi data source to yml template. #2428
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -223,3 +223,12 @@ | |
# Set the value of this setting to true to start exploring wizard | ||
# functionality in Visualization. | ||
# wizard.enabled: false | ||
|
||
# Set the value of this setting to true to enables the experimental multiple data source | ||
# support feature. Use with caution. | ||
#data_source.enabled: false | ||
# Set the value of these settings to custermize crypto materials to encryption saved credentials | ||
# in data sources. | ||
Comment on lines
+230
to
+231
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can/should we link to documentation for these settings? It's not at all clear from this file alone what valid values here might look like. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I don't see other settings has reference to document in the template. there is another PR which provides document of all settings in README #2448 |
||
#data_source.encryption.wrappingKeyName: 'changeme' | ||
#data_source.encryption.wrappingKeyNamespace: 'changeme' | ||
#data_source.encryption.wrappingKey: [0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: For consistency, can we add a space between the comment delimiter and the config key?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the convention in this file is:
#
#
So that it is easy for people to differentiate comment/explanations vs. sample configs