Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.0][CI] Clean up for BWC tests & run only on PRs for backports #2388

Merged
merged 1 commit into from
Sep 20, 2022

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport dfe13d6 from #1955

…1955)

Issue:
n/a

Backport PRs will also run actions for pushs and PRs which is just
unneeded double work everytime. So this prevents that.

Also, BWC will run a complete array for every job in the matrix.
Now we set the environment variable to prevents the running of
the default versions.

Finally updating date range of filter tests to be more inclusive for
new test data.

Signed-off-by: Kawika Avilla <[email protected]>
(cherry picked from commit 57a751e)
(cherry picked from commit dfe13d6)
@opensearch-trigger-bot opensearch-trigger-bot bot requested a review from a team as a code owner September 19, 2022 22:33
@kavilla kavilla changed the title [Backport 2.0] [Backport 2.x] [CI] Clean up for BWC tests & run only on PRs for backports [Backport 2.0][CI] Clean up for BWC tests & run only on PRs for backports Sep 19, 2022
@kavilla
Copy link
Member

kavilla commented Sep 19, 2022

The original PR backport failed: #1955. Now succeeds.

@ashwin-pc
Copy link
Member

@kavilla so do we close thisPR then?

@kavilla
Copy link
Member

kavilla commented Sep 19, 2022

@kavilla so do we close thisPR then?

We should get this in because this fixes the problem related to the BWC tests failing on 2.0 and stop over utilizing resources (blocking other github actions from running), because backports will trigger github actions to run for push and PR. Which everytime the PR is updated, will trigger both.

@kavilla
Copy link
Member

kavilla commented Sep 20, 2022

Functional test 11 will fail until #2387 is merged

@kavilla kavilla merged commit a6aaf6e into 2.0 Sep 20, 2022
@github-actions github-actions bot deleted the backport/backport-1955-to-2.0 branch September 20, 2022 17:16
pjfitzgibbons pushed a commit to pjfitzgibbons/OpenSearch-Dashboards that referenced this pull request Oct 24, 2022
…ch-project#1948) (opensearch-project#1955) (opensearch-project#2388)

Issue:
n/a

Backport PRs will also run actions for pushs and PRs which is just
unneeded double work everytime. So this prevents that.

Also, BWC will run a complete array for every job in the matrix.
Now we set the environment variable to prevents the running of
the default versions.

Finally updating date range of filter tests to be more inclusive for
new test data.

Signed-off-by: Kawika Avilla <[email protected]>
(cherry picked from commit 57a751e)
(cherry picked from commit dfe13d6)

Co-authored-by: Kawika Avilla <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants