[D&D] Fixes time series for new chart types #2309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshuarrrr
reviewed
Sep 9, 2022
| export const getPipelineParams = (): BuildPipelineParams => { | ||
| const timeFilter = getTimeFilter(); | ||
| return { | ||
| // TODO: this will blow up for time x dimensions |
There was a problem hiding this comment.
Isn't this what the PR fixes?
| import { VislibRootState } from '../common/types'; | ||
| import { getValueAxes } from '../common/get_value_axes'; | ||
| import { VislibRootState, getValueAxes, getPipelineParams } from '../common'; |
Signed-off-by: Ashwin Pc <[email protected]>
ashwin-pc
force-pushed
the
fix/timeseries
branch
from
e2ea2aa to
cc000f5
Compare
|
Removed the TODO :) |
Signed-off-by: Ashwin Pc <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #2309 +/- ##
==========================================
- Coverage 66.55% 66.55% -0.01%
==========================================
Files 3169 3170 +1
Lines 60313 60316 +3
Branches 9182 9181 -1
==========================================
+ Hits 40141 40142 +1
- Misses 17979 17981 +2
Partials 2193 2193
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
joshuarrrr
approved these changes
Sep 9, 2022
kavilla
approved these changes
Sep 12, 2022
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 12, 2022
* fixes time series for new chart types Signed-off-by: Ashwin Pc <[email protected]> * moves translate to source string Signed-off-by: Ashwin Pc <[email protected]> Signed-off-by: Ashwin Pc <[email protected]> (cherry picked from commit 93f6872)
sipopo
pushed a commit
to sipopo/OpenSearch-Dashboards
that referenced
this pull request
Sep 14, 2022
* fixes time series for new chart types Signed-off-by: Ashwin Pc <[email protected]> * moves translate to source string Signed-off-by: Ashwin Pc <[email protected]> Signed-off-by: Ashwin Pc <[email protected]> Signed-off-by: Sergey V. Osipov <[email protected]>
kavilla
added a commit
that referenced
this pull request
Sep 15, 2022
* fixes time series for new chart types * moves translate to source string Signed-off-by: Ashwin Pc <[email protected]> (cherry picked from commit 93f6872) Co-authored-by: Ashwin P Chandran <[email protected]> Co-authored-by: Kawika Avilla <[email protected]>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 21, 2022
* fixes time series for new chart types Signed-off-by: Ashwin Pc <[email protected]> * moves translate to source string Signed-off-by: Ashwin Pc <[email protected]> Signed-off-by: Ashwin Pc <[email protected]> (cherry picked from commit 93f6872)
kavilla
pushed a commit
that referenced
this pull request
Sep 21, 2022
* fixes time series for new chart types * moves translate to source string Signed-off-by: Ashwin Pc <[email protected]> (cherry picked from commit 93f6872)
AMoo-Miki
added
bug
sipopo
pushed a commit
to sipopo/OpenSearch-Dashboards
that referenced
this pull request
Dec 16, 2022
* fixes time series for new chart types Signed-off-by: Ashwin Pc <[email protected]> * moves translate to source string Signed-off-by: Ashwin Pc <[email protected]> Signed-off-by: Ashwin Pc <[email protected]> Signed-off-by: Sergey V. Osipov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ashwin Pc [email protected]
Description
Fixes rendering timeseries for the bar, line and area charts.
Issues Resolved
#2307
Check List
yarn test:jestyarn test:jest_integrationyarn test:ftr