-
Notifications
You must be signed in to change notification settings - Fork 916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[UX] Change timeline icon #2162
[UX] Change timeline icon #2162
Conversation
Issue Resolved: opensearch-project#2155 Signed-off-by: Bandini Bhopi <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on the screenshot provided,this looks great. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
dont we need to update the version of OUI used? |
No. This icon is from OUI 1.0.0. We used existing timeline icon. So no need to update OUI version for this change. |
Just wanted to verify this: #658 and it worked fine. I think we can backport this change |
Issue Resolved: #2155 Signed-off-by: Bandini Bhopi <[email protected]> Signed-off-by: Bandini Bhopi <[email protected]> (cherry picked from commit 763b7f0)
Issue Resolved: #2155 Signed-off-by: Bandini Bhopi <[email protected]> Signed-off-by: Bandini Bhopi <[email protected]> (cherry picked from commit 763b7f0)
Issue Resolved: #2155 Signed-off-by: Bandini Bhopi <[email protected]> Signed-off-by: Bandini Bhopi <[email protected]> (cherry picked from commit 763b7f0) Co-authored-by: Bandini <[email protected]> Co-authored-by: Josh Romero <[email protected]>
Issue Resolved: opensearch-project#2155 Signed-off-by: Bandini Bhopi <[email protected]> Signed-off-by: Bandini Bhopi <[email protected]> Signed-off-by: Sergey V. Osipov <[email protected]>
Signed-off-by: Bandini Bhopi [email protected]
Description
Changed Timeline Viz icon on the visualization type selection screen.
SC
Issues Resolved
#2155
Check List
yarn test:jest
yarn test:jest_integration
yarn test:ftr