Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PURIFY] Removes unused Jenkis shell scripts #211

Merged
merged 1 commit into from
Mar 22, 2021

Conversation

mihirsoni
Copy link
Contributor

Signed-off-by: Mihir Soni [email protected]

@kavilla
Copy link
Member

kavilla commented Mar 22, 2021

Some of these? It still doesn't build oss by default right? Like we still need to pass the flag so are these actually unused? Or we straight up dont run Jenkins tests?

Update: Oh I looked at this PR before the other one.

Copy link
Member

@kavilla kavilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few questions.

@odfe-release-bot
Copy link

✅   DCO Check Passed

@mihirsoni mihirsoni requested a review from ananzh March 22, 2021 16:32
@mihirsoni mihirsoni merged commit 01b46fe into opensearch-project:main Mar 22, 2021
raintygao pushed a commit to raintygao/OpenSearch-Dashboards that referenced this pull request Mar 11, 2024
…ct#211)

* Add workspace column/filter into saved objects page

Signed-off-by: Hailong Cui <[email protected]>

fix failed test case

Signed-off-by: Hailong Cui <[email protected]>

move workspace column to its own folder

Signed-off-by: Hailong Cui <[email protected]>

* default workspace

Signed-off-by: Hailong Cui <[email protected]>

fix test case

Signed-off-by: Hailong Cui <[email protected]>

add test case

Signed-off-by: Hailong Cui <[email protected]>

remove hide import

Signed-off-by: Hailong Cui <[email protected]>

* address review comments

Signed-off-by: Hailong Cui <[email protected]>

---------

Signed-off-by: Hailong Cui <[email protected]>
SuZhou-Joe pushed a commit to SuZhou-Joe/OpenSearch-Dashboards that referenced this pull request Mar 18, 2024
…ct#211)

* Add workspace column/filter into saved objects page

Signed-off-by: Hailong Cui <[email protected]>

fix failed test case

Signed-off-by: Hailong Cui <[email protected]>

move workspace column to its own folder

Signed-off-by: Hailong Cui <[email protected]>

* default workspace

Signed-off-by: Hailong Cui <[email protected]>

fix test case

Signed-off-by: Hailong Cui <[email protected]>

add test case

Signed-off-by: Hailong Cui <[email protected]>

remove hide import

Signed-off-by: Hailong Cui <[email protected]>

* address review comments

Signed-off-by: Hailong Cui <[email protected]>

---------

Signed-off-by: Hailong Cui <[email protected]>
Hailong-am added a commit to Hailong-am/OpenSearch-Dashboards that referenced this pull request Apr 15, 2024
* Add workspace column/filter into saved objects page

Signed-off-by: Hailong Cui <[email protected]>

fix failed test case

Signed-off-by: Hailong Cui <[email protected]>

move workspace column to its own folder

Signed-off-by: Hailong Cui <[email protected]>

* default workspace

Signed-off-by: Hailong Cui <[email protected]>

fix test case

Signed-off-by: Hailong Cui <[email protected]>

add test case

Signed-off-by: Hailong Cui <[email protected]>

remove hide import

Signed-off-by: Hailong Cui <[email protected]>

* address review comments

Signed-off-by: Hailong Cui <[email protected]>

---------

Signed-off-by: Hailong Cui <[email protected]>
ZilongX pushed a commit that referenced this pull request Apr 17, 2024
)

* Add workspace filter into saved objects page (#211)

* Add workspace column/filter into saved objects page

Signed-off-by: Hailong Cui <[email protected]>

fix failed test case

Signed-off-by: Hailong Cui <[email protected]>

move workspace column to its own folder

Signed-off-by: Hailong Cui <[email protected]>

* default workspace

Signed-off-by: Hailong Cui <[email protected]>

fix test case

Signed-off-by: Hailong Cui <[email protected]>

add test case

Signed-off-by: Hailong Cui <[email protected]>

remove hide import

Signed-off-by: Hailong Cui <[email protected]>

* address review comments

Signed-off-by: Hailong Cui <[email protected]>

---------

Signed-off-by: Hailong Cui <[email protected]>

* replace default workspace with public workspace (#322)

Signed-off-by: Hailong Cui <[email protected]>

* Add workspace filter

Signed-off-by: Hailong Cui <[email protected]>

* revert query params change

Signed-off-by: Hailong Cui <[email protected]>

* udpate test case name to more clear

Signed-off-by: Hailong Cui <[email protected]>

* support public workspace

Signed-off-by: Hailong Cui <[email protected]>

* Add changelog

Signed-off-by: Hailong Cui <[email protected]>

* update fetchExportByTypeAndSearch parameter

Co-authored-by: SuZhou-Joe <[email protected]>
Signed-off-by: Hailong Cui <[email protected]>

* remove virtrual public workspace

Signed-off-by: Hailong Cui <[email protected]>

* update comments

Signed-off-by: Hailong Cui <[email protected]>

* fix public workspace query when permission is not enabled

Signed-off-by: Hailong Cui <[email protected]>

* home dashboards/listing page only show public workspace data

Signed-off-by: Hailong Cui <[email protected]>

* Add more test case

Signed-off-by: Hailong Cui <[email protected]>

---------

Signed-off-by: Hailong Cui <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
Co-authored-by: SuZhou-Joe <[email protected]>
Hailong-am added a commit to Hailong-am/OpenSearch-Dashboards that referenced this pull request Apr 18, 2024
…ensearch-project#6458)

* Add workspace filter into saved objects page (opensearch-project#211)

* Add workspace column/filter into saved objects page

Signed-off-by: Hailong Cui <[email protected]>

fix failed test case

Signed-off-by: Hailong Cui <[email protected]>

move workspace column to its own folder

Signed-off-by: Hailong Cui <[email protected]>

* default workspace

Signed-off-by: Hailong Cui <[email protected]>

fix test case

Signed-off-by: Hailong Cui <[email protected]>

add test case

Signed-off-by: Hailong Cui <[email protected]>

remove hide import

Signed-off-by: Hailong Cui <[email protected]>

* address review comments

Signed-off-by: Hailong Cui <[email protected]>

---------

Signed-off-by: Hailong Cui <[email protected]>

* replace default workspace with public workspace (opensearch-project#322)

Signed-off-by: Hailong Cui <[email protected]>

* Add workspace filter

Signed-off-by: Hailong Cui <[email protected]>

* revert query params change

Signed-off-by: Hailong Cui <[email protected]>

* udpate test case name to more clear

Signed-off-by: Hailong Cui <[email protected]>

* support public workspace

Signed-off-by: Hailong Cui <[email protected]>

* Add changelog

Signed-off-by: Hailong Cui <[email protected]>

* update fetchExportByTypeAndSearch parameter

Co-authored-by: SuZhou-Joe <[email protected]>
Signed-off-by: Hailong Cui <[email protected]>

* remove virtrual public workspace

Signed-off-by: Hailong Cui <[email protected]>

* update comments

Signed-off-by: Hailong Cui <[email protected]>

* fix public workspace query when permission is not enabled

Signed-off-by: Hailong Cui <[email protected]>

* home dashboards/listing page only show public workspace data

Signed-off-by: Hailong Cui <[email protected]>

* Add more test case

Signed-off-by: Hailong Cui <[email protected]>

---------

Signed-off-by: Hailong Cui <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
Co-authored-by: SuZhou-Joe <[email protected]>
Hailong-am added a commit to Hailong-am/OpenSearch-Dashboards that referenced this pull request Apr 19, 2024
…ensearch-project#6458)

* Add workspace filter into saved objects page (opensearch-project#211)

* Add workspace column/filter into saved objects page

Signed-off-by: Hailong Cui <[email protected]>

fix failed test case

Signed-off-by: Hailong Cui <[email protected]>

move workspace column to its own folder

Signed-off-by: Hailong Cui <[email protected]>

* default workspace

Signed-off-by: Hailong Cui <[email protected]>

fix test case

Signed-off-by: Hailong Cui <[email protected]>

add test case

Signed-off-by: Hailong Cui <[email protected]>

remove hide import

Signed-off-by: Hailong Cui <[email protected]>

* address review comments

Signed-off-by: Hailong Cui <[email protected]>

---------

Signed-off-by: Hailong Cui <[email protected]>

* replace default workspace with public workspace (opensearch-project#322)

Signed-off-by: Hailong Cui <[email protected]>

* Add workspace filter

Signed-off-by: Hailong Cui <[email protected]>

* revert query params change

Signed-off-by: Hailong Cui <[email protected]>

* udpate test case name to more clear

Signed-off-by: Hailong Cui <[email protected]>

* support public workspace

Signed-off-by: Hailong Cui <[email protected]>

* Add changelog

Signed-off-by: Hailong Cui <[email protected]>

* update fetchExportByTypeAndSearch parameter

Co-authored-by: SuZhou-Joe <[email protected]>
Signed-off-by: Hailong Cui <[email protected]>

* remove virtrual public workspace

Signed-off-by: Hailong Cui <[email protected]>

* update comments

Signed-off-by: Hailong Cui <[email protected]>

* fix public workspace query when permission is not enabled

Signed-off-by: Hailong Cui <[email protected]>

* home dashboards/listing page only show public workspace data

Signed-off-by: Hailong Cui <[email protected]>

* Add more test case

Signed-off-by: Hailong Cui <[email protected]>

---------

Signed-off-by: Hailong Cui <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
Co-authored-by: SuZhou-Joe <[email protected]>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Apr 22, 2024
)

* Add workspace filter into saved objects page (#211)

* Add workspace column/filter into saved objects page

Signed-off-by: Hailong Cui <[email protected]>

fix failed test case

Signed-off-by: Hailong Cui <[email protected]>

move workspace column to its own folder

Signed-off-by: Hailong Cui <[email protected]>

* default workspace

Signed-off-by: Hailong Cui <[email protected]>

fix test case

Signed-off-by: Hailong Cui <[email protected]>

add test case

Signed-off-by: Hailong Cui <[email protected]>

remove hide import

Signed-off-by: Hailong Cui <[email protected]>

* address review comments

Signed-off-by: Hailong Cui <[email protected]>

---------

Signed-off-by: Hailong Cui <[email protected]>

* replace default workspace with public workspace (#322)

Signed-off-by: Hailong Cui <[email protected]>

* Add workspace filter

Signed-off-by: Hailong Cui <[email protected]>

* revert query params change

Signed-off-by: Hailong Cui <[email protected]>

* udpate test case name to more clear

Signed-off-by: Hailong Cui <[email protected]>

* support public workspace

Signed-off-by: Hailong Cui <[email protected]>

* Add changelog

Signed-off-by: Hailong Cui <[email protected]>

* update fetchExportByTypeAndSearch parameter

Co-authored-by: SuZhou-Joe <[email protected]>
Signed-off-by: Hailong Cui <[email protected]>

* remove virtrual public workspace

Signed-off-by: Hailong Cui <[email protected]>

* update comments

Signed-off-by: Hailong Cui <[email protected]>

* fix public workspace query when permission is not enabled

Signed-off-by: Hailong Cui <[email protected]>

* home dashboards/listing page only show public workspace data

Signed-off-by: Hailong Cui <[email protected]>

* Add more test case

Signed-off-by: Hailong Cui <[email protected]>

---------

Signed-off-by: Hailong Cui <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
Co-authored-by: SuZhou-Joe <[email protected]>
(cherry picked from commit 9408e49)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md
SuZhou-Joe pushed a commit that referenced this pull request Apr 23, 2024
) (#6580)

* Add workspace filter into saved objects page (#211)

* Add workspace column/filter into saved objects page

Signed-off-by: Hailong Cui <[email protected]>

fix failed test case

Signed-off-by: Hailong Cui <[email protected]>

move workspace column to its own folder

Signed-off-by: Hailong Cui <[email protected]>

* default workspace

Signed-off-by: Hailong Cui <[email protected]>

fix test case

Signed-off-by: Hailong Cui <[email protected]>

add test case

Signed-off-by: Hailong Cui <[email protected]>

remove hide import

Signed-off-by: Hailong Cui <[email protected]>

* address review comments

Signed-off-by: Hailong Cui <[email protected]>

---------

Signed-off-by: Hailong Cui <[email protected]>

* replace default workspace with public workspace (#322)

Signed-off-by: Hailong Cui <[email protected]>

* Add workspace filter

Signed-off-by: Hailong Cui <[email protected]>

* revert query params change

Signed-off-by: Hailong Cui <[email protected]>

* udpate test case name to more clear

Signed-off-by: Hailong Cui <[email protected]>

* support public workspace

Signed-off-by: Hailong Cui <[email protected]>

* Add changelog

Signed-off-by: Hailong Cui <[email protected]>

* update fetchExportByTypeAndSearch parameter

Co-authored-by: SuZhou-Joe <[email protected]>
Signed-off-by: Hailong Cui <[email protected]>

* remove virtrual public workspace

Signed-off-by: Hailong Cui <[email protected]>

* update comments

Signed-off-by: Hailong Cui <[email protected]>

* fix public workspace query when permission is not enabled

Signed-off-by: Hailong Cui <[email protected]>

* home dashboards/listing page only show public workspace data

Signed-off-by: Hailong Cui <[email protected]>

* Add more test case

Signed-off-by: Hailong Cui <[email protected]>

---------

Signed-off-by: Hailong Cui <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
Co-authored-by: SuZhou-Joe <[email protected]>
(cherry picked from commit 9408e49)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants