Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to start OS Dashboards with a newer and compatible nodejs version #2091

Closed
wants to merge 177 commits into from
Closed
Show file tree
Hide file tree
Changes from 25 commits
Commits
Show all changes
177 commits
Select commit Hold shift + click to select a range
4ec3e36
[Visualizations] Adds visConfig.title and uiState to build pipeline f…
fbaligand Sep 6, 2022
176d7b3
Persists index field on agg type change if possible (#2227)
ashwin-pc Sep 6, 2022
a813370
[BUG] fix healthcheck logic to expect object and return ids (#2277)
kavilla Sep 7, 2022
1038c6d
Update API Specs for dev console (#2226)
kristenTian Sep 8, 2022
166945e
[D&D] Adds Bar line and Area charts to Wizard (#2266)
ashwin-pc Sep 8, 2022
6018ea9
[D&D] Fixes time series for new chart types (#2309)
ashwin-pc Sep 12, 2022
b594ad1
Update caniuse (#2322)
abbyhu2000 Sep 12, 2022
c46bd14
Add v2.3.0 release notes (#2318)
noCharger Sep 12, 2022
fb86e42
README.md for saving index pattern relationship (#2276)
abbyhu2000 Sep 13, 2022
d205f3a
add node fiber to improve performance (#2319)
abbyhu2000 Sep 13, 2022
e3356c5
add path ignore for markdown files (#2312)
abbyhu2000 Sep 14, 2022
93d3d11
Merge branch 'opensearch-project:main' into nodejs_check
sipopo Sep 14, 2022
83b048e
Merge branch 'opensearch-project:main' into nodejs_check
sipopo Sep 15, 2022
3a29bbb
return my changes
sipopo Sep 15, 2022
4b5bb53
change cosmetics
sipopo Sep 15, 2022
fd1fc14
Merge branch 'main' into nodejs_check
sipopo Sep 20, 2022
343a1e7
Merge branch 'opensearch-project:main' into nodejs_check
sipopo Sep 22, 2022
c5c8c4a
Changed warning massage and fix test for it
sipopo Oct 20, 2022
2353cf8
Merge branch 'main' into nodejs_check
sipopo Oct 20, 2022
759cbb7
remove space at the end of lines
sipopo Oct 21, 2022
5bdfb2b
Merge branch 'nodejs_check' of github.com:sipopo/OpenSearch-Dashboard…
sipopo Oct 21, 2022
3d050ba
fix error code
sipopo Oct 21, 2022
2b28788
fix error.code )
sipopo Oct 21, 2022
ee88dc9
Merge branch 'main' into nodejs_check
sipopo Oct 21, 2022
3090d5b
Add CHANGELOG
sipopo Oct 25, 2022
3ae1805
Merge branch 'main' into nodejs_check
dblock Nov 3, 2022
8e15731
Update src/setup_node_env/node_version_validator.js
sipopo Nov 20, 2022
443f136
Add changes by @Amoo-MIKI
sipopo Dec 16, 2022
3770965
Merge branch 'main' into nodejs_check
sipopo Dec 16, 2022
0685b04
Change timeline icon (#2162)
bandinib-amzn Sep 6, 2022
a746d4a
[Visualizations] Adds visConfig.title and uiState to build pipeline f…
fbaligand Sep 6, 2022
b55b9bd
Persists index field on agg type change if possible (#2227)
ashwin-pc Sep 6, 2022
cbc01f6
[BUG] fix healthcheck logic to expect object and return ids (#2277)
kavilla Sep 7, 2022
59479fb
Update API Specs for dev console (#2226)
kristenTian Sep 8, 2022
a7115b2
[D&D] Adds Bar line and Area charts to Wizard (#2266)
ashwin-pc Sep 8, 2022
16c8d38
[D&D] Fixes time series for new chart types (#2309)
ashwin-pc Sep 12, 2022
fae3296
Update caniuse (#2322)
abbyhu2000 Sep 12, 2022
a0d195c
Add v2.3.0 release notes (#2318)
noCharger Sep 12, 2022
0fe69a9
README.md for saving index pattern relationship (#2276)
abbyhu2000 Sep 13, 2022
aad58d1
add node fiber to improve performance (#2319)
abbyhu2000 Sep 13, 2022
eb4b2e4
add path ignore for markdown files (#2312)
abbyhu2000 Sep 14, 2022
91ee76d
Use a forced CSP-compliant interpreter with Vega visualizations (#2352)
AMoo-Miki Sep 14, 2022
57ffa0f
Bump moment-timezone from 0.5.34 to 0.5.37 (#2361)
ashwin-pc Sep 15, 2022
00be307
return my changes
sipopo Sep 15, 2022
cb4c5d6
change cosmetics
sipopo Sep 15, 2022
19b4a96
Add index pattern info when loading embeddable (#2363)
abbyhu2000 Sep 15, 2022
607ad19
Fixes management app breadcrumb error (#2344)
ashwin-pc Sep 16, 2022
86a19dc
MultiDataSource feature merge (#2334)
kristenTian Sep 19, 2022
f096ef5
Add updated_at column to objects' tables (#1218)
RoyiSitbon Sep 20, 2022
4e00035
Upgrade geckodriver to 3.0.2 to partially fix CVE-2022-33987 (#2166)
CCongWang Sep 20, 2022
4ccb1c5
[CI][Tests] Add BWC tests for 2.4.0 (#2393)
manasvinibs Sep 22, 2022
d1247c5
Remove extra typo from README. (#2403)
sagar-rout Sep 22, 2022
467a969
Changed warning massage and fix test for it
sipopo Oct 20, 2022
0b08b32
remove space at the end of lines
sipopo Oct 21, 2022
202d975
Adding @abbyhu2000 as a Dashboards co-maintainer (#2407)
ashwin-pc Sep 23, 2022
a9b6086
Add CHANGELOG.md and related workflows (#2414)
kavilla Sep 26, 2022
155a248
Adding @zengyan-amazon as a Dashboards co-maintainer (#2419)
seanneumann Sep 26, 2022
0d72b8d
Updating @tmarkley to Emeritus status (#2423)
seanneumann Sep 27, 2022
71cafea
[Vis Builder] Misc Bar chart fixes (#2401)
ashwin-pc Sep 28, 2022
8fdb191
Fix yarn.lock file (#2432)
abbyhu2000 Sep 29, 2022
fc62286
[Viz Builder] State validation before dispatching and loading (#2351)
abbyhu2000 Sep 29, 2022
6e10927
Support legacy client for data source (#2204)
zhongnansu Sep 29, 2022
cd87279
Add @kristenTian as maintainer. (#2450)
zengyan-amazon Sep 29, 2022
9304c9c
Bumps `percy-agent` to use non-beta version (#2415)
kavilla Sep 29, 2022
dbe565a
fix d3-color and potential security issue (#2454)
ananzh Sep 30, 2022
4d630c0
[Plugin Helpers] Facilitate version changes (#2398)
AMoo-Miki Sep 30, 2022
c9ecfd9
[MD] Fix view single document issue by updating low-level search call…
zhongnansu Oct 3, 2022
2a0c5fd
Add sample config for multi data source in yml config template (#2428)
zengyan-amazon Oct 4, 2022
5df8bd1
Add dataSource & dataSourceManagement ReadMe (#2448)
kristenTian Oct 4, 2022
46375ec
Adds v1.3.6 release notes (#2480)
joshuarrrr Oct 4, 2022
b14d121
[Chore] Visualize link fix (#2395)
BSFishy Oct 4, 2022
b621c54
[VizBuilder] Create a new wizard directly on a dashboard (#2384)
abbyhu2000 Oct 4, 2022
fb00116
[CI] Run functional test repo as workflow (#2503)
kavilla Oct 5, 2022
5c3b7fe
[MD] Address UX comments for index pattern pages (#2505)
kristenTian Oct 6, 2022
9a7e833
[MD] UX updates on data source page & validation changes (#2521)
mpabba3003 Oct 6, 2022
224650e
[MD] Display error toast for create index pattern with data source (#…
zhongnansu Oct 6, 2022
c548512
[MD] Update copy on index patten config DS step (#2527)
kristenTian Oct 7, 2022
8f5056a
[MD] new UX changes for password fields and update password modal in …
mpabba3003 Oct 10, 2022
78c1ac6
Edit wizard directly on dashboard (#2508)
abbyhu2000 Oct 10, 2022
3bfabf4
Updates functional test readme (#2492)
ashwin-pc Oct 10, 2022
3696483
Add column service to index pattern & Register data source column (#2…
kristenTian Oct 11, 2022
8ba1e35
[MD] Add experimental callout for index pattern section (#2523)
yibow98 Oct 11, 2022
0916619
[MD] Add data source signing support (#2510)
noCharger Oct 11, 2022
a868ce5
[MD] UX refactor for datasource create page (#2501)
yibow98 Oct 11, 2022
6f6d5b8
[MD]Add data source config to opensearch-dashboards-docker (#2557)
kristenTian Oct 12, 2022
8dcaadc
[MD] Make text content dynamically translated & update unit tests (#2…
yibow98 Oct 13, 2022
a902811
[MD] Adding unit test coverage for Update data source management (#2567)
mpabba3003 Oct 14, 2022
f2fc745
[MD] skip data source view when pick default (#2574)
kristenTian Oct 14, 2022
ca2d031
Change classname prefix wiz to vb (#2581)
abbyhu2000 Oct 17, 2022
459fa6a
Change wizard to vis_builder in file names and paths (#2587)
abbyhu2000 Oct 17, 2022
8b75268
Add @zhongnansu as maintainer (#2590)
kristenTian Oct 18, 2022
9d5e7df
[Vis Builder] Update vislib params and misc fixes (#2610)
ashwin-pc Oct 19, 2022
a4f85bd
fix error code
sipopo Oct 21, 2022
2726f63
fix error.code )
sipopo Oct 21, 2022
8f25a16
[MD] Datasource management Edit/Update page UX updates (#2629)
mpabba3003 Oct 20, 2022
de2b984
[MD]Address comments from UX signoff meeting-Datasource list and crea…
yibow98 Oct 20, 2022
167951b
Rename wizard to visBuilder in i18n id and formatted message id (#2635)
abbyhu2000 Oct 20, 2022
7fd8e21
Add CHANGELOG
sipopo Oct 25, 2022
1514ed5
[Windows] Facilitate building of OSD and plugins (#2601)
AMoo-Miki Oct 21, 2022
324f0f0
Rename wizard to visBuilder in class name, type name and function nam…
abbyhu2000 Oct 21, 2022
aaeda4d
[BUG]fix suggestion list cutoff issue (#2607)
ananzh Oct 21, 2022
198b3f2
[MD] Address UX comments on index pattern stack (#2611)
kristenTian Oct 22, 2022
b4ca07f
[CVE 2022-3517] Bump minimatch to 3.0.5 and [IBM X-Force ID: 220063]…
himsgupta1122 Oct 22, 2022
d33f900
Apply get indice error handling in step index pattern (#2652)
kristenTian Oct 25, 2022
d7b6efe
[Vis Builder] Bug fixes for datasource picker and auto time interval …
ashwin-pc Oct 26, 2022
89f7bf4
Last Updated Timestamp for visbuilder saved object is getting Generat…
AbhishekReddy1127 Oct 26, 2022
dcd2ee8
[MD] Refactor data source server side error handling (#2661)
zhongnansu Oct 27, 2022
313ca79
[Vis Builder] Rename wizard on save modal and visualization table (#2…
abbyhu2000 Oct 27, 2022
87c9d68
[@osd/cross-platform] Adds cross-platform helpers (#2681)
AMoo-Miki Oct 28, 2022
904701f
Change save object type, wizard id and name to visBuilder (#2673)
abbyhu2000 Oct 28, 2022
cf8f26f
[CVE] Bump loader-utils to 2.0.3 to fix CVE-2022-37601 (#2689)
ZilongX Oct 28, 2022
b234559
Add extension point in saved object management to register namespaces…
cwperks Oct 28, 2022
b6650ea
Removed Leftover X Pack references #2517 (#2638)
vimalMK Oct 31, 2022
add7c56
Revert "[@osd/cross-platform] Adds cross-platform helpers (#2681)" (#…
joshuarrrr Oct 31, 2022
c908203
[MD] Add design documents of multiple data source feature (#2538)
zhongnansu Oct 31, 2022
693b429
Adds @osd/cross-platform (#2703)
AMoo-Miki Nov 1, 2022
b67f2e7
[MD]Update MD data source documentation link (#2693)
kristenTian Nov 1, 2022
29b086e
Add `Skip-Changelog` label to skip changelog verification on certain …
AMoo-Miki Nov 2, 2022
dfde15a
Enable visbuilder by default (#2725)
ashwin-pc Nov 2, 2022
6855c0f
[Save Object Aggregation View] Fix for export all after scroll count …
cwperks Nov 2, 2022
1b6dde7
Update backport workflow to ignore changelog conflicts (#2729)
AMoo-Miki Nov 2, 2022
4273887
Tweak multiple data source design doc (#2724)
kristenTian Nov 2, 2022
0e4eec3
[Chore] Refactor and improve Discover field summaries (#2391)
joshuarrrr Nov 3, 2022
5aa57ff
Removes Add Integration button (#2723)
bandinib-amzn Nov 3, 2022
5d70422
Prevent backport workflow from running on umerged PRs (#2746)
AMoo-Miki Nov 3, 2022
9d7967c
[Vis Builder] Enable VisBuilder cypress tests (#2728)
ashwin-pc Nov 3, 2022
fec31f5
Update src/setup_node_env/node_version_validator.js
sipopo Nov 20, 2022
4c030bf
Add changes by @Amoo-MIKI
sipopo Dec 16, 2022
ab5217f
[CI] update backport custom branch name (#2766)
kavilla Nov 3, 2022
4fe1349
[Legacy Maps Plugin] Prevent reverse-tabnabbing (#2540)
AMoo-Miki Nov 3, 2022
bc14ef0
change geckodriver version to make consistency (#2772)
ananzh Nov 4, 2022
f40aa48
[Vis Builder] Add an experimental table visualization in vis builder …
ananzh Nov 4, 2022
ca7faac
Security-CVEs fixes guidelines (#2674)
himsgupta1122 Nov 4, 2022
50ac94c
[MD] Update default audit log path (#2793)
kristenTian Nov 4, 2022
ba0982e
[Vis Builder] Add field summary popovers (#2682)
joshuarrrr Nov 4, 2022
a31a21e
Bump makelogs to remove dependency on got (#2801)
AMoo-Miki Nov 4, 2022
df25e13
Change VisBuilder flag for docker config (#2804)
ashwin-pc Nov 5, 2022
89ed89b
[MD] Add explicit no spellcheck on password fields (#2818)
kristenTian Nov 7, 2022
7b8faf1
[Bug][Table Visualization] Fix first column sort issue (#2828)
ananzh Nov 9, 2022
f1f638f
Temporarily prevents `task-kill` exceptions on Windows when it is pas…
AMoo-Miki Nov 9, 2022
09edbdc
Add the release runbook to RELEASING.md (#2533)
noCharger Nov 10, 2022
bdc989b
[VisBuilder] [BUG] fix empty workspace animation does not work in fir…
raintygao Nov 11, 2022
da7b742
[Vis Builder] Removed Hard Coded Strings and Used i18n to transalte (…
AbhishekReddy1127 Nov 14, 2022
f5880c3
[Doc] Document `charts` plugin (#2695)
joshuarrrr Nov 18, 2022
046fd07
Setup OpenSearch plugin dependencies on cluster snapshot (#2734)
manasvinibs Nov 18, 2022
111700e
[WS-2021-0638][Security] bump mocha to 10.1.0 (#2711)
ananzh Nov 21, 2022
87d186a
OSD-2847 bump del version to fix race condition (#2873)
DanielBelmes Nov 21, 2022
344e520
[i18n] Register `ru`, `ru-RU` locale (#2817)
dmitry-by-step-logic Nov 22, 2022
8373c92
[Doc] Correct "help" command to reflect actual behaviour (#2810)
Patrick-Clausen Nov 22, 2022
4769ef5
Add 2.4.0 release notes (#2881)
kavilla Nov 23, 2022
30b2fee
Add BWC tests for 2.5.0 (#2890)
manasvinibs Nov 23, 2022
e66f1d7
Reenable CI tests for feature branches (#2908)
ashwin-pc Nov 24, 2022
8773686
Fixes folder timestamps being updated before copying files into them …
AMoo-Miki Nov 30, 2022
1675b91
Fixes incorrect validation of time values in JUnit Reporter (#2965)
AMoo-Miki Dec 1, 2022
bfb9db7
[Windows] Make `yarn pkg-version` work across platforms (#2963)
AMoo-Miki Dec 1, 2022
ed9f17b
Add Windows CI to the workflow (#2966)
AMoo-Miki Dec 1, 2022
031c3d4
Makes tests covering plugin installation on cluster snapshots work ac…
AMoo-Miki Dec 1, 2022
9dc6b05
Bump loader-utils from 2.0.3 to 2.0.4 (#2892)
dependabot[bot] Dec 1, 2022
d8bf14b
Corrects the usage of leaflet-vega parameters (#3005)
AMoo-Miki Dec 2, 2022
b5553ac
Add @manasvinibs as maintainer (#3006)
kavilla Dec 2, 2022
4a9fd9f
[Vis Builder] Add global data persistence for vis builder (#2896)
abbyhu2000 Dec 7, 2022
c625a57
Automates chromedriver version selection for tests (#2990)
AMoo-Miki Dec 8, 2022
aeed823
Fixes `no-restricted-path` false-positives when `allowSameFolder` is …
AMoo-Miki Dec 8, 2022
b2fb0db
[Doc] Add readme for global query persistence (#3001)
abbyhu2000 Dec 13, 2022
18ed706
[MD] Feature test connection (#2973)
mpabba3003 Dec 13, 2022
c8ee9af
[Chore] Add release notes for 1.3.7 (#3066)
joshuarrrr Dec 13, 2022
9c34260
[Chore] Add 2.4.1 release notes (#3070)
joshuarrrr Dec 13, 2022
897d59b
[Table Visualization][BUG] Fix Url content display (#2918)
ananzh Dec 15, 2022
78a00b2
[Tests] Bumps `chromedriver` to v107 (#3017)
tmarkley Dec 15, 2022
9d93970
Removes minimatch manual resolution (#3019)
tmarkley Dec 15, 2022
4553682
Bumps simple-git from 3.4.0 to 3.15.0 (#3036)
kristenTian Dec 15, 2022
8411201
Fix boktorbb alias. (#3085)
dblock Dec 15, 2022
3e1f49c
Bump decode-uri-component from 0.2.0 to 0.2.2 (#3009)
dependabot[bot] Dec 15, 2022
106b141
merge differents
sipopo Dec 16, 2022
658081c
remove some spaces
sipopo Dec 16, 2022
df33397
add ; -)
sipopo Dec 16, 2022
41fa0a2
Merge branch 'main' into nodejs_check
sipopo Dec 20, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ Inspired from [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
### 🛡 Security

### 📈 Features/Enhancements

* Ability to start OS Dashboards with a newer and compatible nodejs version ([#2091](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/2091))
* [MD] Support legacy client for data source ([#2204](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/2204))
* [MD] Add data source signing support ([#2510](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/2510))
* [Plugin Helpers] Facilitate version changes ([#2398](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/2398))
Expand Down
19 changes: 16 additions & 3 deletions src/setup_node_env/node_version_validator.js
Original file line number Diff line number Diff line change
Expand Up @@ -37,18 +37,31 @@ var rawRequiredVersion = (pkg && pkg.engines && pkg.engines.node) || null;
var requiredVersion = rawRequiredVersion ? 'v' + rawRequiredVersion : rawRequiredVersion;
var currentVersionMajorMinorPatch = currentVersion.match(/^v(\d+)\.(\d+)\.(\d+)/);
var requiredVersionMajorMinorPatch = requiredVersion.match(/^v(\d+)\.(\d+)\.(\d+)/);
var currentMinorPatch = currentVersionMajorMinorPatch[2].concat(
'.',
currentVersionMajorMinorPatch[3]
);
var requiredMinorPatch = requiredVersionMajorMinorPatch[2].concat(
'.',
requiredVersionMajorMinorPatch[3]
);
var isVersionValid =
currentVersionMajorMinorPatch[1] === requiredVersionMajorMinorPatch[1] &&
currentVersionMajorMinorPatch[2] === requiredVersionMajorMinorPatch[2] &&
parseInt(currentVersionMajorMinorPatch[3], 10) >= parseInt(requiredVersionMajorMinorPatch[3], 10);
parseFloat(currentMinorPatch) >= parseFloat(requiredMinorPatch);
var isMinorValid = currentVersionMajorMinorPatch[2] === requiredVersionMajorMinorPatch[2];

// Validates current the NodeJS version compatibility when OpenSearch Dashboards starts.
if (!isVersionValid) {
sipopo marked this conversation as resolved.
Show resolved Hide resolved
sipopo marked this conversation as resolved.
Show resolved Hide resolved
var errorMessage =
`OpenSearch Dashboards was built with ${requiredVersion} and does not support the current Node.js version ${currentVersion}. ` +
`Please use Node.js ${requiredVersion} or a higher patch version.`;

// Actions to apply when validation fails: error report + exit.
console.error(errorMessage);
process.exit(1);
} else if (!isMinorValid) {
sipopo marked this conversation as resolved.
Show resolved Hide resolved
// Validates Minor version of the NodeJS
var warnMessage =
`You're using an untested version of Node.js. OpenSearch Dashboards has been tested to work with Node.js ` +
`${requiredVersion}. Your current version is ${currentVersion}.`;
console.warn(warnMessage);
}
14 changes: 11 additions & 3 deletions src/setup_node_env/node_version_validator.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -64,8 +64,8 @@ describe('NodeVersionValidator', function () {
);
});

it('should run the script WITH error if the minor version is higher', function (done) {
testValidateNodeVersion(done, requiredNodeVersionWithDiff(0, +1, 0), true);
it('should run the script WITH warning message if the minor version is higher', function (done) {
testValidateNodeVersion(done, requiredNodeVersionWithDiff(0, +1, 0), false, true);
});

it('should run the script WITH error if the minor version is lower', function (done) {
Expand All @@ -87,12 +87,13 @@ function requiredNodeVersionWithDiff(majorDiff, minorDiff, patchDiff) {
return `v${major}.${minor}.${patch}`;
}

function testValidateNodeVersion(done, versionToTest, expectError = false) {
function testValidateNodeVersion(done, versionToTest, expectError = false, expectWarning = false) {
var processVersionOverwrite = `Object.defineProperty(process, 'version', { value: '${versionToTest}', writable: true });`;
var command = `node -e "${processVersionOverwrite}require('./node_version_validator.js')"`;

exec(command, { cwd: __dirname }, function (error, _stdout, stderr) {
expect(stderr).toBeDefined();

if (expectError) {
expect(error.code).toBe(1);

Expand All @@ -101,6 +102,13 @@ function testValidateNodeVersion(done, versionToTest, expectError = false) {
`Please use Node.js ${REQUIRED_NODE_JS_VERSION} or a higher patch version.\n`;

expect(stderr).toStrictEqual(speficicErrorMessage);
} else if (expectWarning) {
expect(error).toBeNull();

var speficicWarningMessage =
`You're using an untested version of Node.js. OpenSearch Dashboards has been tested to work with Node.js ` +
`${REQUIRED_NODE_JS_VERSION}. Your current version is ${versionToTest}.\n`;
expect(stderr).toStrictEqual(speficicWarningMessage);
} else {
expect(error).toBeNull();
expect(stderr).toHaveLength(0);
Expand Down