-
Notifications
You must be signed in to change notification settings - Fork 974
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] Adding Github Issue / PR templates #206
Conversation
Signed-off-by: Mihir Soni <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One question but otherwise looks good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few comments but perhaps they were on purpose.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 to other comments. Otherwise LGTM.
Signed-off-by: Mihir Soni <[email protected]>
fb4cbee
✅ DCO Check Passed |
1 similar comment
✅ DCO Check Passed |
…search-project#206) * fix: logic passed after validate failed Signed-off-by: Lin Wang <[email protected]> * test: add integration tests for workspace saved objects client wrapper Signed-off-by: Lin Wang <[email protected]> * test: remove timeout Signed-off-by: Lin Wang <[email protected]> * test: refactor with fixed scoped client and ignore delete error in clear all Signed-off-by: Lin Wang <[email protected]> * fix: workspaces can't be query Signed-off-by: Lin Wang <[email protected]> * update to latest license header Signed-off-by: Lin Wang <[email protected]> * remove skip migrate and remove keyword suffix Signed-off-by: Lin Wang <[email protected]> --------- Signed-off-by: Lin Wang <[email protected]>
Signed-off-by: Mihir Soni [email protected]