-
Notifications
You must be signed in to change notification settings - Fork 923
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Telemetry plugin cluster info rename error #2043
[BUG] Telemetry plugin cluster info rename error #2043
Conversation
Introduced when renaming, I accidentally typed the param incorrectly. Issue: n/a Signed-off-by: Kawika Avilla <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #2043 +/- ##
==========================================
+ Coverage 67.49% 67.51% +0.01%
==========================================
Files 3076 3077 +1
Lines 59144 59184 +40
Branches 8989 9003 +14
==========================================
+ Hits 39919 39957 +38
- Misses 17041 17042 +1
- Partials 2184 2185 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a link to the PR or commit where the wrong name was introduced? Also, a note on how the bug was detected and fix validated would be useful in lieu of an issue. Do we need any additional test coverage or cases?
Good call outs! |
Origin: 2e9d038#diff-78de4f9b624b3e4781283b5c5ab84428a1aa0920fb3ae86f60453d9d524922a7 Introduced when renaming, I accidentally typed the param incorrectly. Issue: n/a Signed-off-by: Kawika Avilla <[email protected]> (cherry picked from commit 28fd642)
I have updated the merge commit with the commit reference as requested: 2e9d038#diff-78de4f9b624b3e4781283b5c5ab84428a1aa0920fb3ae86f60453d9d524922a7. Also I believe the problem is related to this: #1660, why it won't necessarily cause issues runtime but the TypeScript error was ignored in the compiler. I discovered it by coincidentally unfortunately. Nothing specific. |
Origin: 2e9d038#diff-78de4f9b624b3e4781283b5c5ab84428a1aa0920fb3ae86f60453d9d524922a7 Introduced when renaming, I accidentally typed the param incorrectly. Issue: n/a Signed-off-by: Kawika Avilla <[email protected]> (cherry picked from commit 28fd642) Co-authored-by: Kawika Avilla <[email protected]>
Origin: 2e9d038#diff-78de4f9b624b3e4781283b5c5ab84428a1aa0920fb3ae86f60453d9d524922a7 Introduced when renaming, I accidentally typed the param incorrectly. Issue: n/a Signed-off-by: Kawika Avilla <[email protected]>
…2043) Origin: opensearch-project@2e9d038#diff-78de4f9b624b3e4781283b5c5ab84428a1aa0920fb3ae86f60453d9d524922a7 Introduced when renaming, I accidentally typed the param incorrectly. Issue: n/a Signed-off-by: Kawika Avilla <[email protected]>
Description
Introduced when renaming, I accidentally typed the param
incorrectly.
Signed-off-by: Kawika Avilla [email protected]
Issues Resolved
n/a
Check List
yarn test:jest
yarn test:jest_integration
yarn test:ftr