-
Notifications
You must be signed in to change notification settings - Fork 919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Rename] .opensearch-dashboards index to .opensearch_dashboards (#37) #188
Merged
boktorbb
merged 3 commits into
opensearch-project:dashboards
from
boktorbb:rename-index
Mar 18, 2021
Merged
[Rename] .opensearch-dashboards index to .opensearch_dashboards (#37) #188
boktorbb
merged 3 commits into
opensearch-project:dashboards
from
boktorbb:rename-index
Mar 18, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ DCO Check Passed |
seanneumann
reviewed
Mar 18, 2021
seanneumann
reviewed
Mar 18, 2021
seanneumann
reviewed
Mar 18, 2021
seanneumann
reviewed
Mar 18, 2021
seanneumann
reviewed
Mar 18, 2021
✅ DCO Check Passed |
kavilla
approved these changes
Mar 18, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just the comment about opensearch_dashboards-test
. LGTM
src/core/server/saved_objects/migrations/core/opensearch_index.test.ts
Outdated
Show resolved
Hide resolved
✅ DCO Check Passed |
mihirsoni
approved these changes
Mar 18, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !!
Signed-off-by: Bishoy Boktor <[email protected]>
Signed-off-by: Bishoy Boktor <[email protected]>
Signed-off-by: Bishoy Boktor <[email protected]>
✅ DCO Check Passed |
kavilla
referenced
this pull request
in kavilla/OpenSearch-Dashboards
Mar 19, 2021
… (#188) * [Rename] .opensearch-dashboards index to .opensearch_dashboards (#37) Signed-off-by: Bishoy Boktor <[email protected]> * Address PR comments Signed-off-by: Bishoy Boktor <[email protected]> * Address PR comments Signed-off-by: Bishoy Boktor <[email protected]>
kavilla
pushed a commit
that referenced
this pull request
Mar 20, 2021
…#188) * [Rename] .opensearch-dashboards index to .opensearch_dashboards (#37) Signed-off-by: Bishoy Boktor <[email protected]> * Address PR comments Signed-off-by: Bishoy Boktor <[email protected]> * Address PR comments Signed-off-by: Bishoy Boktor <[email protected]>
mihirsoni
pushed a commit
that referenced
this pull request
Mar 20, 2021
…#188) * [Rename] .opensearch-dashboards index to .opensearch_dashboards (#37) Signed-off-by: Bishoy Boktor <[email protected]> * Address PR comments Signed-off-by: Bishoy Boktor <[email protected]> * Address PR comments Signed-off-by: Bishoy Boktor <[email protected]>
Hailong-am
added a commit
to Hailong-am/OpenSearch-Dashboards
that referenced
this pull request
Sep 21, 2023
…search-project#188) Signed-off-by: Hailong Cui <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Bishoy Boktor [email protected]