[CI] Update labels for doc issue creation workflow #1789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Example: https://github.com/opensearch-project/OpenSearch-Dashboards/runs/7015324767?check_suite_focus=true If we checkout the run, we can see the run fails with: `Resource not accessible by integration` Which I believe because the `documentation` label is not available in the doc repo. So instead of creating a `documentation` label which seems redudant for a doc repo issue, we should use `dashboards` because it exists and makes it more specific for the doc repo maintainers. Issue: n/a Signed-off-by: Kawika Avilla <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #1789 +/- ##
=======================================
Coverage 67.51% 67.51%
=======================================
Files 3073 3073
Lines 59069 59069
Branches 8963 8963
=======================================
Hits 39881 39881
Misses 17005 17005
Partials 2183 2183 Continue to review full report at Codecov.
|
|
@kavilla Do CI changes like this need to be backported, or will they work for all PRs once merged to main? |
They should but the original doc issue wasn't added to 2.x so it will be a 3.x thing but it should all work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Example:
https://github.com/opensearch-project/OpenSearch-Dashboards/runs/7015324767?check_suite_focus=true
If we checkout the run, we can see the run fails with:
Resource not accessible by integrationWhich I believe because the
documentationlabel is not available in the doc repo. So instead ofcreating a
documentationlabel which seems redudant for a doc repo issue, we should usedashboardsbecause it exists and makes it more specific for the doc repo maintainers.Signed-off-by: Kawika Avilla [email protected]
Issues Resolved
n/a
Check List
yarn test:jestyarn test:jest_integrationyarn test:ftr