[Improvement] Adding noreferrer on doc links

[manasvinibs]

Signed-off-by: manasvis [email protected]

Description

Stemming from this PR: #565. Links inconsistently have noreferrer on the reference.
This change might not include adding noreferrer to all the links in the package, but links which already have 'rel="noopener"' in it to make it consistent throughout the repo as called out in the above PR.

Issues Resolved

#567

Check List

• New functionality includes testing.
  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
    • yarn test:ftr
• New functionality has been documented.
• Commits are signed per the DCO using --signoff

[joshuarrrr]

This is a solid implementation of linked issue.

However, in reviewing, this felt like the kind of thing we shouldn't have to manually worry about for every link. I did a little digging, and it turns out that neither noopeneer nor noreferrer need to be explicitly set when using <EuiLink> components with target="_blank".

Here is where that EUI component calculates the ref values:
https://github.com/elastic/eui/blob/1a5e8429c2db1c331946aede3f85e144fa21d381/src/components/link/link.tsx#L163

noreferrer will always be set by https://github.com/elastic/eui/blob/1a5e8429c2db1c331946aede3f85e144fa21d381/src/services/security/get_secure_rel_for_target.ts#L40-L42

and noopener will be set by
https://github.com/elastic/eui/blob/1a5e8429c2db1c331946aede3f85e144fa21d381/src/services/security/get_secure_rel_for_target.ts#L44-L46

So my recommendation is to update the changes to the 4 <EuiLink> components to remove the rel prop altogether, rather than manually adding noreferrer. (The current changes to <a> strings seem worthwhile to keep)

[codecov-commenter]

Codecov Report

Merging #1709 (980e64f) into main (b2cfb6e) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1709   +/-   ##
=======================================
  Coverage   67.51%   67.51%           
=======================================
  Files        3067     3067           
  Lines       58985    58985           
  Branches     8944     8944           
=======================================
+ Hits        39821    39825    +4     
+ Misses      16985    16982    -3     
+ Partials     2179     2178    -1     

Impacted Files	Coverage Δ
.../core/server/ui_settings/settings/notifications.ts	100.00% <ø> (ø)
src/plugins/data/server/ui_settings.ts	71.42% <ø> (ø)
...ins/home/public/application/components/welcome.tsx	75.55% <ø> (ø)
...ins/telemetry/public/components/opt_in_message.tsx	100.00% <ø> (ø)
...metry/public/components/opted_in_notice_banner.tsx	100.00% <ø> (ø)
...is_default_editor/public/components/agg_select.tsx	0.00% <ø> (ø)
packages/osd-optimizer/src/node/cache.ts	52.77% <0.00%> (+2.77%)	⬆️
...s/osd-optimizer/src/node/node_auto_tranpilation.ts	87.75% <0.00%> (+4.08%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2cfb6e...980e64f. Read the comment docs.

[manasvinibs]

This is a solid implementation of linked issue.

However, in reviewing, this felt like the kind of thing we shouldn't have to manually worry about for every link. I did a little digging, and it turns out that neither noopeneer nor noreferrer need to be explicitly set when using <EuiLink> components with target="_blank".

Here is where that EUI component calculates the ref values: https://github.com/elastic/eui/blob/1a5e8429c2db1c331946aede3f85e144fa21d381/src/components/link/link.tsx#L163

noreferrer will always be set by https://github.com/elastic/eui/blob/1a5e8429c2db1c331946aede3f85e144fa21d381/src/services/security/get_secure_rel_for_target.ts#L40-L42

and noopener will be set by https://github.com/elastic/eui/blob/1a5e8429c2db1c331946aede3f85e144fa21d381/src/services/security/get_secure_rel_for_target.ts#L44-L46

So my recommendation is to update the changes to the 4 <EuiLink> components to remove the rel prop altogether, rather than manually adding noreferrer. (The current changes to <a> strings seem worthwhile to keep)

Thanks Josh for the pointers! Looks like <EuiLink> is already taking care of what we are trying to achieve here. I'll send the updated revision.

[ananzh]

LGTM

[joshuarrrr]

LGTM, thanks for the updates!