Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Rename] telemetry and visualizations inconsistencies #164

Merged

Conversation

kavilla
Copy link
Member

@kavilla kavilla commented Mar 13, 2021

Signed-off-by: Kawika Avilla [email protected]

Issue #, if available:
#37

Description of changes:
The original PRs got merged with the comments on the PR but no update. This might not be the true values but at least having them consistent with what we expect will help in any future update.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link
Contributor

@boktorbb boktorbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Sorry, merged the original PR because I thought we were staying with opensearch_dashboards_uuid

Copy link
Contributor

@mihirsoni mihirsoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !!

@mihirsoni mihirsoni merged commit 0e4abd7 into opensearch-project:dashboards Mar 13, 2021
@kavilla kavilla deleted the rename-small-inconsistency branch March 18, 2021 08:01
kavilla referenced this pull request in kavilla/OpenSearch-Dashboards Mar 19, 2021
kavilla added a commit that referenced this pull request Mar 20, 2021
mihirsoni pushed a commit that referenced this pull request Mar 20, 2021
Hailong-am pushed a commit to Hailong-am/OpenSearch-Dashboards that referenced this pull request Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants