Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates 2.0 release notes with latest commits #1575

Merged
merged 1 commit into from
May 10, 2022

Conversation

tmarkley
Copy link
Contributor

Description

Adds commits from #1552 and #1545. Any new PRs targeted for 2.0 must add an entry to the release notes.

Issues Resolved

Follow-up on #1566

Check List

  • Commits are signed per the DCO using --signoff

@tmarkley tmarkley added docs Improvements or additions to documentation v2.0.0 backport 2.x backport 2.0 labels May 10, 2022
@tmarkley tmarkley requested a review from a team as a code owner May 10, 2022 14:56
@codecov-commenter
Copy link

Codecov Report

Merging #1575 (01a86c9) into main (0afba22) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1575   +/-   ##
=======================================
  Coverage   68.09%   68.09%           
=======================================
  Files        3072     3072           
  Lines       59033    59033           
  Branches     8928     8928           
=======================================
  Hits        40199    40199           
  Misses      16647    16647           
  Partials     2187     2187           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0afba22...01a86c9. Read the comment docs.

@joshuarrrr
Copy link
Member

joshuarrrr commented May 10, 2022

For my own learning, how are you identifying which commits are missing or creating a diff? Or, in other words, what sort of tooling or processes are in place to check that the release notes exhaustively include all the commits to the release branch?

@kavilla
Copy link
Member

kavilla commented May 10, 2022

For my own learning, how are you identifying which commits are missing or creating a diff? Or, in other words, what sort of tooling or processes are in place to check that the release notes exhaustively include all the commits to the release branch?

I believe for 2.0 RC1 since it's was constructed manually with verification. The assumption that any new commit that gets backported to 2.0 should include an update to the release notes that wasn't released in the RC1 and planned to be released in 2.0.

It might not even be exhaustive but currently better than waiting until the final days before release and then begin looking at which changes got included.

@tmarkley
Copy link
Contributor Author

Yeah until we introduce something like release notes drafter it's a manual process.

@tmarkley tmarkley merged commit 2a96761 into opensearch-project:main May 10, 2022
opensearch-trigger-bot bot pushed a commit that referenced this pull request May 10, 2022
Signed-off-by: Tommy Markley <[email protected]>
(cherry picked from commit 2a96761)
opensearch-trigger-bot bot pushed a commit that referenced this pull request May 10, 2022
Signed-off-by: Tommy Markley <[email protected]>
(cherry picked from commit 2a96761)
@joshuarrrr
Copy link
Member

So we'd look at something like 2.0.0-rc1...2.0 to find the commits, it sounds like.

tmarkley pushed a commit that referenced this pull request May 11, 2022
Signed-off-by: Tommy Markley <[email protected]>
(cherry picked from commit 2a96761)
tmarkley pushed a commit that referenced this pull request May 11, 2022
Signed-off-by: Tommy Markley <[email protected]>
(cherry picked from commit 2a96761)
joshuarrrr pushed a commit to joshuarrrr/OpenSearch-Dashboards that referenced this pull request May 11, 2022
kavilla pushed a commit to kavilla/OpenSearch-Dashboards-1 that referenced this pull request Jun 8, 2022
kavilla pushed a commit to kavilla/OpenSearch-Dashboards-1 that referenced this pull request Jun 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x docs Improvements or additions to documentation v2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants