-
Notifications
You must be signed in to change notification settings - Fork 916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enforces equal or increasing code coverage in PRs #1559
Conversation
* Utilizes Codecov yaml configuration: https://docs.codecov.com/docs/codecov-yaml Signed-off-by: Tommy Markley <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #1559 +/- ##
=======================================
Coverage 68.09% 68.09%
=======================================
Files 3072 3072
Lines 59032 59032
Branches 8928 8928
=======================================
+ Hits 40198 40200 +2
+ Misses 16647 16646 -1
+ Partials 2187 2186 -1
Continue to review full report at Codecov.
|
Do we have a testing doctrine or testing goals or metric targets? |
@CPTNB I think our TESTING.md doc covers some of that. We don't currently have a metric goal for tests; I've seen other repositories in the OpenSearch Project target between 70% and 80%, but I'm hesitant to add a target at this point since we have a lot of issues related to testing that we want to address: |
Can we still override it if necessary? Like when we merge the mocha test removal PR or if the diff is minor like -.01%. Some readme update PR's usually have that as the coverage diff |
@ashwin-pc yes, similar to how we can still merge if one of the Build and test checks fail (e.g. a flaky test fails or the version of chromedriver doesn't match GitHub), we maintainers can still choose to merge if the Codecov check fails and there are two approvers. |
* Utilizes Codecov yaml configuration: https://docs.codecov.com/docs/codecov-yaml * The purpose of enforcing increasing code coverage over time is to attempt to improve the quality of changes via testing, reduce the need to request tests in PRs, and stay away from enforcing an ambiguous coverage percentage. Signed-off-by: Tommy Markley <[email protected]> (cherry picked from commit 21d7b6f)
* Utilizes Codecov yaml configuration: https://docs.codecov.com/docs/codecov-yaml * The purpose of enforcing increasing code coverage over time is to attempt to improve the quality of changes via testing, reduce the need to request tests in PRs, and stay away from enforcing an ambiguous coverage percentage. Signed-off-by: Tommy Markley <[email protected]> (cherry picked from commit 21d7b6f)
* Utilizes Codecov yaml configuration: https://docs.codecov.com/docs/codecov-yaml * The purpose of enforcing increasing code coverage over time is to attempt to improve the quality of changes via testing, reduce the need to request tests in PRs, and stay away from enforcing an ambiguous coverage percentage. Signed-off-by: Tommy Markley <[email protected]> (cherry picked from commit 21d7b6f)
* Utilizes Codecov yaml configuration: https://docs.codecov.com/docs/codecov-yaml * The purpose of enforcing increasing code coverage over time is to attempt to improve the quality of changes via testing, reduce the need to request tests in PRs, and stay away from enforcing an ambiguous coverage percentage. Signed-off-by: Tommy Markley <[email protected]> (cherry picked from commit 21d7b6f)
…#1590) * Utilizes Codecov yaml configuration: https://docs.codecov.com/docs/codecov-yaml * The purpose of enforcing increasing code coverage over time is to attempt to improve the quality of changes via testing, reduce the need to request tests in PRs, and stay away from enforcing an ambiguous coverage percentage. Signed-off-by: Tommy Markley <[email protected]> (cherry picked from commit 21d7b6f)
…#1591) * Utilizes Codecov yaml configuration: https://docs.codecov.com/docs/codecov-yaml * The purpose of enforcing increasing code coverage over time is to attempt to improve the quality of changes via testing, reduce the need to request tests in PRs, and stay away from enforcing an ambiguous coverage percentage. Signed-off-by: Tommy Markley <[email protected]> (cherry picked from commit 21d7b6f)
…#1589) * Utilizes Codecov yaml configuration: https://docs.codecov.com/docs/codecov-yaml * The purpose of enforcing increasing code coverage over time is to attempt to improve the quality of changes via testing, reduce the need to request tests in PRs, and stay away from enforcing an ambiguous coverage percentage. Signed-off-by: Tommy Markley <[email protected]> (cherry picked from commit 21d7b6f)
…#1588) * Utilizes Codecov yaml configuration: https://docs.codecov.com/docs/codecov-yaml * The purpose of enforcing increasing code coverage over time is to attempt to improve the quality of changes via testing, reduce the need to request tests in PRs, and stay away from enforcing an ambiguous coverage percentage. Signed-off-by: Tommy Markley <[email protected]> (cherry picked from commit 21d7b6f)
…arch-project#1559) * Utilizes Codecov yaml configuration: https://docs.codecov.com/docs/codecov-yaml * The purpose of enforcing increasing code coverage over time is to attempt to improve the quality of changes via testing, reduce the need to request tests in PRs, and stay away from enforcing an ambiguous coverage percentage. Signed-off-by: Tommy Markley <[email protected]>
…arch-project#1559) * Utilizes Codecov yaml configuration: https://docs.codecov.com/docs/codecov-yaml * The purpose of enforcing increasing code coverage over time is to attempt to improve the quality of changes via testing, reduce the need to request tests in PRs, and stay away from enforcing an ambiguous coverage percentage. Signed-off-by: Tommy Markley <[email protected]>
Description
The purpose of enforcing increasing code coverage over time is to attempt to improve the quality of changes via testing, reduce the need to request tests in PRs, and stay away from enforcing an ambiguous coverage percentage.
Validated the config:
Issues Resolved
N/A
Check List