-
Notifications
You must be signed in to change notification settings - Fork 923
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bumps grunt
from v1.4.1 to v1.5.2
#1451
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this have any conflicts with plugins?
How should we be confirming that? There are no breaking changes in the changelog, but if even a patch bump like #1439 causes issues then we'd have to assume any changes to dependencies could cause conflicts with plugins. |
We need to merge these CVE PRs in for RC1 to address any breaking changes.
If there is a risk to break plugins, shall we point it to this issue and pin plugin owners? Is there a way to keep them updated? |
@ananzh I just added details there. We can address required changes as they are found. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* Addresses CVE-2022-0436. * [CHANGELOG](https://github.com/gruntjs/grunt/blob/v1.5.2/CHANGELOG) Resolves opensearch-project#1450 Signed-off-by: Tommy Markley <[email protected]>
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.x 1.x
# Navigate to the new working tree
cd .worktrees/backport-1.x
# Create a new branch
git switch --create backport/backport-1451-to-1.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 cef9e61e4ead72cb0b5abb88991213b45a0f9801
# Push it to GitHub
git push --set-upstream origin backport/backport-1451-to-1.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.x Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.3 1.3
# Navigate to the new working tree
cd .worktrees/backport-1.3
# Create a new branch
git switch --create backport/backport-1451-to-1.3
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 cef9e61e4ead72cb0b5abb88991213b45a0f9801
# Push it to GitHub
git push --set-upstream origin backport/backport-1451-to-1.3
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.3 Then, create a pull request where the |
* Addresses CVE-2022-0436. * [CHANGELOG](https://github.com/gruntjs/grunt/blob/v1.5.2/CHANGELOG) Resolves opensearch-project#1450 Signed-off-by: Tommy Markley <[email protected]>
* Addresses CVE-2022-0436. * [CHANGELOG](https://github.com/gruntjs/grunt/blob/v1.5.2/CHANGELOG) Resolves #1450 Signed-off-by: Tommy Markley <[email protected]>
Description
Issues Resolved
Resolves #1450
Check List
yarn test:jest
yarn test:jest_integration
yarn test:ftr