[Draft][PoC] multiple OpenSearch data source PoC #1430
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kavilla
previously requested changes
Apr 14, 2022
There was a problem hiding this comment.
Blocking to ensure stability for 2.0.0-rc-1.
@zengyan-amazon do we think we can convert this a draft PR?
6 tasks
tmarkley
reviewed
May 3, 2022
| @@ -0,0 +1,117 @@ | |||
| /* | |||
There was a problem hiding this comment.
You can use the simplified header for new files:
/*
* Copyright OpenSearch Contributors
* SPDX-License-Identifier: Apache-2.0
*/
| const dataSource = request.dataSource ? await context.core.savedObjects.client.get('data-source', request.dataSource) : undefined; | ||
| logger.info(JSON.stringify(dataSource)); | ||
| const dataSourceObj = dataSource!.attributes as any; | ||
| const url = dataSourceObj.endpoint.url; |
There was a problem hiding this comment.
This throws an exception when dataSource is undefined, right? Can we define the type for dataSourceObj?
|
Any particular reason why this PR is targeting |
|
Oh, this is just a PoC PR that is meant for discussion, no plan to merge in, close it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is the PoC of enabling OSD to support visualizations with multiple data sources
Issues Resolved
#1388
Check List
yarn test:jestyarn test:jest_integrationyarn test:ftr