-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[i18n] Internationalization #943
Comments
Need list of translations |
Thanks for opening! If I understand, if a user wants to add a new language they would;
I think that makes sense to me - we'll need to figure out how one goes approving a PR for a language they don't speak but I think that's more operational. Long-term, we should consider creating a path for the end user to select the language preference of their choice so an Dashboard instance can be vended in multiple languages at the same time. |
# [24.4.0](elastic/elastic-charts@v24.3.0...v24.4.0) (2020-12-09) ### Bug Fixes * empty labels on debug state ([opensearch-project#940](elastic/elastic-charts#940)) ([3d1281b](elastic/elastic-charts@3d1281b)) ### Features * allow use of functions for y, y0, split and stack accessors ([opensearch-project#943](elastic/elastic-charts#943)) ([e881723](elastic/elastic-charts@e881723))
We've now created the i18n OpenSearch Dashboards plugin. @ahopp @kavilla, is there more work to be done for this issue? |
I think we could close the issue, since the plugin is released. |
Is your feature request related to a problem? Please describe.
The problem arises from: #772
Originally an internationalization plugin existed in a proprietary section of the legacy application. The plugin would host internationalized messages and formats for different locales in a JSON file and a call to
/translations/{locale}
would return that file. The application is already built out to handle i18n messages but doesn't have anything return for the locale provided.Describe the solution you'd like
Create an i18n SERVER plugin (non-UI), that is not part of the OpenSearch Dashboards repo that returns the correct values from a provided locale under the route
/translations
.Example response:
Describe alternatives you've considered
The plugin could go into the Dashboards repo but that is just another thing the main repo will have to manage. If it is external it will be much easier to contribute translations.
Additional context
We name the plugin some form of
i18n
/l10n
/internationalization
/localization
and not translation. Translation doesn't really seem correct since I wouldn't say "translating the currency".We could also change the api call from the main repo to call an updated endpoint.
The text was updated successfully, but these errors were encountered: