Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG][VisBuilder Migration] Missing filter and query (_q state) when reload a saved legacy vis builder #5646

Closed
ananzh opened this issue Dec 28, 2023 · 1 comment
Closed

[BUG][VisBuilder Migration] Missing filter and query (_q state) when reload a saved legacy vis builder #5646

ananzh opened this issue Dec 28, 2023 · 1 comment
Labels
bug Something isn't working data explorer Issues related to the Data Explorer project v2.14.0 vis builder

Comments

@ananzh
Copy link
Member

ananzh commented Dec 28, 2023 •
edited
Loading

Describe the bug
No filter and query (_q state) when reload a saved legacy vis builder. This is a legacy issue, because current vis builder does not save filter and query (_q state) properly. See #5643. Once it is resolved, this should no longer be a problem. But the previous saved one might not be fixable. Customer might need to add query and filter back manually.

Again, this is not a migration issue. This issue is document for verification purpose.

To Reproduce

  • Download 2.10 OpenSearch
wget https://artifacts.opensearch.org/releases/bundle/opensearch/2.10.0/opensearch-2.10.0-linux-x64.tar.gz
  • Unzip file
tar -xvf <path to OS 2.10>
  • List all plugins and remove them
./bin/opensearch-plugin list
./bin/opensearch-plugin remove opensearch-alerting
  • Start OpenSearch
./opensearch-tar-install.sh
  • Start 2.10 OSD
  • Save a legacy VisBuilder in 2.10 as visbuilder-old
  • Copy data folder from OpenSearch 2.10 to main
  • Start OpenSearch main and OSD with new vis builder. Could use my branch vb-migration-de
  • Click legacy vis builder visbuilder-old
  • Observe missing filter and query

Expected behavior
No backward compatibility issue

OpenSearch Version
main
@ananzh ananzh added bug Something isn't working untriaged vis builder data explorer Issues related to the Data Explorer project v2.12.0 labels Dec 28, 2023
@ananzh ananzh added v2.13.0 and removed v2.12.0 labels Feb 7, 2024
@ashwin-pc ashwin-pc added v2.14.0 and removed v2.13.0 labels Mar 19, 2024
This was referenced Apr 11, 2024
Closed
Merged
ananzh added a commit to ananzh/OpenSearch-Dashboards that referenced this issue Apr 17, 2024
@ananzh
[VisBuilder] Fix filter and query bugs
e187833 
In this PR:
add filter and query in vb
remove saveDisabledReason
clean filterManager when start vb
add opensearch_dashboards_context to embeddable. This can add filter and query in the expression.

Issue Resolve
opensearch-project#5643
opensearch-project#5644
opensearch-project#5645
opensearch-project#5646
opensearch-project#6512

Signed-off-by: Anan Zhuang <[email protected]>
ananzh added a commit to ananzh/OpenSearch-Dashboards that referenced this issue Apr 17, 2024
@ananzh
[VisBuilder] Fix filter and query bugs
a084711 
In this PR:
add filter and query in vb
remove saveDisabledReason
clean filterManager when start vb
add opensearch_dashboards_context to embeddable. This can add filter and query in the expression.

Issue Resolve
opensearch-project#5643
opensearch-project#5644
opensearch-project#5645
opensearch-project#5646
opensearch-project#6512

Signed-off-by: Anan Zhuang <[email protected]>
ananzh added a commit to ananzh/OpenSearch-Dashboards that referenced this issue Apr 17, 2024
@ananzh
[VisBuilder] Fix filter and query bugs
76a9443 
In this PR:
add filter and query in vb
remove saveDisabledReason
clean filterManager when start vb
add opensearch_dashboards_context to embeddable. This can add filter and query in the expression.

Issue Resolve
opensearch-project#5643
opensearch-project#5644
opensearch-project#5645
opensearch-project#5646
opensearch-project#6512

Signed-off-by: Anan Zhuang <[email protected]>
ananzh added a commit to ananzh/OpenSearch-Dashboards that referenced this issue Apr 17, 2024
@ananzh
[VisBuilder] Fix filter and query bugs
2a46488 
In this PR:
add filter and query in vb
remove saveDisabledReason
clean filterManager when start vb
add opensearch_dashboards_context to embeddable. This can add filter and query in the expression.

Issue Resolve
opensearch-project#5643
opensearch-project#5644
opensearch-project#5645
opensearch-project#5646
opensearch-project#6512

Signed-off-by: Anan Zhuang <[email protected]>
ananzh added a commit to ananzh/OpenSearch-Dashboards that referenced this issue Apr 18, 2024
@ananzh
[VisBuilder] Fix filter and query bugs
59bf1f2 
In this PR:
add filter and query in vb
remove saveDisabledReason
clean filterManager when start vb
add opensearch_dashboards_context to embeddable. This can add filter and query in the expression.

Issue Resolve
opensearch-project#5643
opensearch-project#5644
opensearch-project#5645
opensearch-project#5646
opensearch-project#6512

Signed-off-by: Anan Zhuang <[email protected]>
ananzh added a commit to ananzh/OpenSearch-Dashboards that referenced this issue Apr 18, 2024
@ananzh
[VisBuilder] Fix filter and query bugs
b70cdc3 
In this PR:
add filter and query in vb
remove saveDisabledReason
clean filterManager when start vb
add opensearch_dashboards_context to embeddable. This can add filter and query in the expression.

Issue Resolve
opensearch-project#5643
opensearch-project#5644
opensearch-project#5645
opensearch-project#5646
opensearch-project#6512

Signed-off-by: Anan Zhuang <[email protected]>
ananzh added a commit that referenced this issue Apr 22, 2024
@ananzh
[VisBuilder] Fix filter and query bugs
d8bb7bf 
In this PR:
add filter and query in vb
remove saveDisabledReason
clean filterManager when start vb
add opensearch_dashboards_context to embeddable. This can add filter and query in the expression.

Issue Resolve
#5643
#5644
#5645
#5646
#6512

Signed-off-by: Anan Zhuang <[email protected]>
ananzh added a commit to ananzh/OpenSearch-Dashboards that referenced this issue Apr 25, 2024
@ananzh
[VisBuilder] Fix filter and query bugs
0119d9e 
In this PR:
add filter and query in vb
clean filterManager when start vb
add opensearch_dashboards_context to embeddable. This can add filter and query in the expression.

Issue Resolve
opensearch-project#5643
opensearch-project#5644
opensearch-project#5646
opensearch-project#6512

Signed-off-by: Anan Zhuang <[email protected]>
@ananzh ananzh mentioned this issue Apr 25, 2024
Open
4 tasks
ananzh added a commit to ananzh/OpenSearch-Dashboards that referenced this issue Apr 29, 2024
@ananzh
[VisBuilder] Fix filter and query bugs
c871042 
In this PR:
add filter and query in vb
clean filterManager when start vb
add opensearch_dashboards_context to embeddable. This can add filter and query in the expression.

Issue Resolve
opensearch-project#5643
opensearch-project#5644
opensearch-project#5646
opensearch-project#6512

Signed-off-by: Anan Zhuang <[email protected]>
ananzh added a commit to ananzh/OpenSearch-Dashboards that referenced this issue Apr 29, 2024
@ananzh
[VisBuilder] Fix filter and query bugs
a197807 
In this PR:
add filter and query in vb
clean filterManager when start vb
add opensearch_dashboards_context to embeddable. This can add filter and query in the expression.

Issue Resolve
opensearch-project#5643
opensearch-project#5644
opensearch-project#5646
opensearch-project#6512

Signed-off-by: Anan Zhuang <[email protected]>
ananzh added a commit to ananzh/OpenSearch-Dashboards that referenced this issue Apr 29, 2024
@ananzh
[VisBuilder] Fix filter and query bugs
947df9f 
In this PR:
add filter and query in vb
clean filterManager when start vb
add opensearch_dashboards_context to embeddable. This can add filter and query in the expression.

Issue Resolve
opensearch-project#5643
opensearch-project#5644
opensearch-project#5646
opensearch-project#6512

Signed-off-by: Anan Zhuang <[email protected]>
ananzh added a commit to ananzh/OpenSearch-Dashboards that referenced this issue Apr 29, 2024
@ananzh
[VisBuilder] Fix filter and query bugs
63175d5 
In this PR:
add filter and query in vb
clean filterManager when start vb
add opensearch_dashboards_context to embeddable. This can add filter and query in the expression.

Issue Resolve
opensearch-project#5643
opensearch-project#5644
opensearch-project#5646
opensearch-project#6512

Signed-off-by: Anan Zhuang <[email protected]>
ananzh added a commit to ananzh/OpenSearch-Dashboards that referenced this issue Apr 30, 2024
@ananzh
[VisBuilder] Fix filter and query bugs
f2d0ef6 
In this PR:
add filter and query in vb
clean filterManager when start vb
add opensearch_dashboards_context to embeddable. This can add filter and query in the expression.

Issue Resolve
opensearch-project#5643
opensearch-project#5644
opensearch-project#5646
opensearch-project#6512

Signed-off-by: Anan Zhuang <[email protected]>
ananzh added a commit that referenced this issue Apr 30, 2024
@ananzh @AMoo-Miki
[VisBuilder ] Fix filter and query bugs in the saved objects (#6460)
0ac9db3 
* [VisBuilder] Fix filter and query bugs

In this PR:
add filter and query in vb
clean filterManager when start vb
add opensearch_dashboards_context to embeddable. This can add filter and query in the expression.

Issue Resolve
#5643
#5644
#5646
#6512

Signed-off-by: Anan Zhuang <[email protected]>


---------

Signed-off-by: Anan Zhuang <[email protected]>
Co-authored-by: Miki <[email protected]>
opensearch-trigger-bot bot pushed a commit that referenced this issue Apr 30, 2024
@github-actions
[VisBuilder ] Fix filter and query bugs in the saved objects (#6460)
ce26f7b 
* [VisBuilder] Fix filter and query bugs

In this PR:
add filter and query in vb
clean filterManager when start vb
add opensearch_dashboards_context to embeddable. This can add filter and query in the expression.

Issue Resolve
#5643
#5644
#5646
#6512

Signed-off-by: Anan Zhuang <[email protected]>

---------

Signed-off-by: Anan Zhuang <[email protected]>
Co-authored-by: Miki <[email protected]>
(cherry picked from commit 0ac9db3)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md
ananzh pushed a commit that referenced this issue Apr 30, 2024
@opensearch-trigger-bot @AMoo-Miki
[VisBuilder ] Fix filter and query bugs in the saved objects (#6460) (#…
73c76d1 
…6686)

* [VisBuilder] Fix filter and query bugs

In this PR:
add filter and query in vb
clean filterManager when start vb
add opensearch_dashboards_context to embeddable. This can add filter and query in the expression.

Issue Resolve
#5643
#5644
#5646
#6512

Signed-off-by: Anan Zhuang <[email protected]>

---------

Signed-off-by: Anan Zhuang <[email protected]>
Co-authored-by: Miki <[email protected]>
(cherry picked from commit 0ac9db3)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@ananzh
Copy link
Member Author

ananzh commented May 4, 2024

This has been resolve in 2.14. Close it.

@ananzh ananzh closed this as completed May 4, 2024
LDrago27 pushed a commit to LDrago27/OpenSearch-Dashboards that referenced this issue Jun 3, 2024
@ananzh @AMoo-Miki @LDrago27
[VisBuilder ] Fix filter and query bugs in the saved objects (opensea…
ab2bafd 
…rch-project#6460)

* [VisBuilder] Fix filter and query bugs

In this PR:
add filter and query in vb
clean filterManager when start vb
add opensearch_dashboards_context to embeddable. This can add filter and query in the expression.

Issue Resolve
opensearch-project#5643
opensearch-project#5644
opensearch-project#5646
opensearch-project#6512

Signed-off-by: Anan Zhuang <[email protected]>


---------

Signed-off-by: Anan Zhuang <[email protected]>
Co-authored-by: Miki <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working data explorer Issues related to the Data Explorer project v2.14.0 vis builder
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ashwin-pc @ananzh