Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Discover Tab Search doesn't work #5468

Closed
liamhess opened this issue Nov 13, 2023 · 2 comments · Fixed by #5484
Closed

[BUG] Discover Tab Search doesn't work #5468

liamhess opened this issue Nov 13, 2023 · 2 comments · Fixed by #5484
Assignees
@abbyhu2000
Labels
bug Something isn't working

Comments

@liamhess
Copy link

Describe the bug

In the Discovery tab of the new 2.11 Dashboards the index pattern search bar doesn't work. I tested it on a colleague's MacOS Sonoma and it also didn't work.

To Reproduce
Steps to reproduce the behavior:

  1. Ingest a lot of unnecessary indices
  2. Create index patterns
  3. try to search for them in the discovery tab

Expected behavior
Usually it should filter the index patterns so that only the ones are visible that match my search.

OpenSearch Version
2.11.0

Dashboards Version
2.11.0

Plugins

I used the default docker-compose from the quickstart with no plugin modifications so to my understanding it has the Security plugin and I don't know what else

Screenshots

searchvideo.mp4

Host/Environment (please complete the following information):

  • OS: MacOS Sonoma 14.0
  • Browser and version: Arc Version 1.15.1
@liamhess liamhess added bug Something isn't working untriaged labels Nov 13, 2023
@liamhess liamhess changed the title [BUG] [BUG] Discover Tab Search doesn't work Nov 13, 2023
@AMoo-Miki
Copy link
Collaborator

Thanks Liam for pointing this out.

@abbyhu2000
Copy link
Member

abbyhu2000 commented Nov 15, 2023 •
edited
Loading

Were able to reproduce this bug. And there is another issue opened that is related to this: #5319

This bug seems to be caused by this commit 1e980fa. After removing the commit, the search functionality works fine. @AMoo-Miki @kavilla

This commit also adds two extra white line to the bottom of the drop down list which looks buggy. Could you take a look at this bug? @mengweieric

@abbyhu2000 abbyhu2000 mentioned this issue Nov 15, 2023
Closed
@mengweieric mengweieric mentioned this issue Nov 16, 2023
Merged
7 tasks
@kavilla kavilla linked a pull request Nov 21, 2023 that will close this issue
[Data source] Fix datasource filtering issue #5484
Merged
7 tasks
kavilla pushed a commit that referenced this issue Nov 29, 2023
@mengweieric
[Data source] Fix datasource filtering issue (#5484)
dadfefa 
Fixes data source filtering issue within Discover. When typing into the index pattern
field it will filter out and highlight the value being typed.

Issue resolved:
#5533
#5499
#5468
#5319

Signed-off-by: Eric <[email protected]>
opensearch-trigger-bot bot pushed a commit that referenced this issue Nov 29, 2023
@github-actions
[Data source] Fix datasource filtering issue (#5484)
9c09d87 
Fixes data source filtering issue within Discover. When typing into the index pattern
field it will filter out and highlight the value being typed.

Issue resolved:
#5533
#5499
#5468
#5319

Signed-off-by: Eric <[email protected]>
(cherry picked from commit dadfefa)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this issue Nov 29, 2023
@github-actions
[Data source] Fix datasource filtering issue (#5484)
c5a2c73 
Fixes data source filtering issue within Discover. When typing into the index pattern
field it will filter out and highlight the value being typed.

Issue resolved:
#5533
#5499
#5468
#5319

Signed-off-by: Eric <[email protected]>
(cherry picked from commit dadfefa)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ashwin-pc pushed a commit that referenced this issue Nov 30, 2023
@opensearch-trigger-bot @github-actions
[Data source] Fix datasource filtering issue (#5484) (#5554)
592b27d 
Fixes data source filtering issue within Discover. When typing into the index pattern
field it will filter out and highlight the value being typed.

Issue resolved:
#5533
#5499
#5468
#5319


(cherry picked from commit dadfefa)

Signed-off-by: Eric <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ananzh pushed a commit that referenced this issue Dec 13, 2023
@opensearch-trigger-bot @github-actions
[Data source] Fix datasource filtering issue (#5484) (#5553)
2473939 
Fixes data source filtering issue within Discover. When typing into the index pattern
field it will filter out and highlight the value being typed.

Issue resolved:
#5533
#5499
#5468
#5319


(cherry picked from commit dadfefa)

Signed-off-by: Eric <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abbyhu2000 abbyhu2000

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Data source] Fix datasource filtering issue mengweieric/OpenSearch-Dashboards
3 participants
@AMoo-Miki @abbyhu2000 @liamhess