[Test] unit test opt_in_security_example_flyout.test.tsx is skipped now #520
Comments
ananzh
added a commit
to ananzh/OpenSearch-Dashboards
that referenced
this issue
Jun 23, 2021
All the unit tests related to unused telemetry are temporarily skipped after the fork. Unit tests of the disabled telemetry functions should also be modified correspondingly. To build a clean unit test, we decide to modify and enable all the working unit tests. This PR checks and enables three test suites in src/plugins/telemetry_management_section including opt_in_example_flyout.test.tsx, opt_in_security_example_flyout.test.tsx, and telemetry_management_section.test.tsx. Issues resolved: opensearch-project#519 opensearch-project#520 opensearch-project#521 Signed-off-by: Anan Zhuang <[email protected]>
5 tasks
ananzh
added a commit
that referenced
this issue
Jun 26, 2021
All the unit tests related to unused telemetry are temporarily skipped after the fork. Unit tests of the disabled telemetry functions should also be modified correspondingly. To build a clean unit test, we decide to modify and enable all the working unit tests. This PR checks and enables three test suites in src/plugins/telemetry_management_section including opt_in_example_flyout.test.tsx, opt_in_security_example_flyout.test.tsx, and telemetry_management_section.test.tsx. Issues resolved: #519 #520 #521 Signed-off-by: Anan Zhuang <[email protected]>
kavilla
pushed a commit
that referenced
this issue
Jun 26, 2021
All the unit tests related to unused telemetry are temporarily skipped after the fork. Unit tests of the disabled telemetry functions should also be modified correspondingly. To build a clean unit test, we decide to modify and enable all the working unit tests. This PR checks and enables three test suites in src/plugins/telemetry_management_section including opt_in_example_flyout.test.tsx, opt_in_security_example_flyout.test.tsx, and telemetry_management_section.test.tsx. Issues resolved: #519 #520 #521 Signed-off-by: Anan Zhuang <[email protected]>
kavilla
pushed a commit
that referenced
this issue
Jun 26, 2021
All the unit tests related to unused telemetry are temporarily skipped after the fork. Unit tests of the disabled telemetry functions should also be modified correspondingly. To build a clean unit test, we decide to modify and enable all the working unit tests. This PR checks and enables three test suites in src/plugins/telemetry_management_section including opt_in_example_flyout.test.tsx, opt_in_security_example_flyout.test.tsx, and telemetry_management_section.test.tsx. Issues resolved: #519 #520 #521 Signed-off-by: Anan Zhuang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the issue
Currently,
opt_in_security_example_flyout.test.tsxtest suite is skipped. To make a clean unit test, we want to explore and decide whether we still need to keep it as skipped.To Reproduce
Run:
yarn test:jest {path to opt_in_security_example_flyout.test.tsx}Expected behavior
explore the skipped unit tests, check:
can we enable all? if yes, create a PR and close the issue
can we remove all? if yes, create a PR and close the issue
should we keep all? if yes, describe the reasons in the issue.
The final output is expected to be a cleaned unit test with all the skipped ones being checked.
OpenSearch Version
OpenSearch 1.0.0
Dashboards Version
Dashboards 1.0.0
The text was updated successfully, but these errors were encountered: