Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Dashboards 2.9 is sending request with extra & for request #5187

Closed
seraphjiang opened this issue Oct 3, 2023 · 1 comment · Fixed by #5190
Closed

[BUG] Dashboards 2.9 is sending request with extra & for request #5187

seraphjiang opened this issue Oct 3, 2023 · 1 comment · Fixed by #5190
Assignees
@AMoo-Miki
Labels
bug Something isn't working v2.11.0

Comments

@seraphjiang
Copy link
Member

seraphjiang commented Oct 3, 2023 •
edited
Loading

Dashboards 2.9 is sending request with extra & for this request, e.g.

GET /_dashboards/api/saved_objects/_find?default_search_operator=AND&&has_reference=%7B%22type%22%3A%22visualization%22%2C%22id%22%3A%22334084f0-52fd-11e8-a160-89cc2ad9e8e2%22%7D&page=1&per_page=100&&type=augment-vis

this will break functionality of downstream service rely on standard query string pattern, which single question mark is used as a separator

https://en.wikipedia.org/wiki/Query_string
@seraphjiang seraphjiang added bug Something isn't working untriaged labels Oct 3, 2023
@seraphjiang seraphjiang changed the title [BUG] Dashboards 2.7 is sending request with extra & for request [BUG] Dashboards 2.9 is sending request with extra & for request Oct 3, 2023
@seanneumann
Copy link
Contributor

Assigning to @ashwin-pc as he has some context.

@AMoo-Miki AMoo-Miki assigned AMoo-Miki and unassigned ashwin-pc Oct 3, 2023
AMoo-Miki added a commit to AMoo-Miki/OpenSearch-Dashboards that referenced this issue Oct 3, 2023
@AMoo-Miki
Fix vis-augmenter forming empty key-value pairs in its calls to the s…
977a106 
…avedObject API

Fixes opensearch-project#5187

Signed-off-by: Miki <[email protected]>
@AMoo-Miki AMoo-Miki mentioned this issue Oct 3, 2023
Merged
8 tasks
AMoo-Miki added a commit to AMoo-Miki/OpenSearch-Dashboards that referenced this issue Oct 3, 2023
@AMoo-Miki
Fix visAugmenter forming empty key-value pairs in its calls to the …
e1f3a1a 
…`SavedObject` API

Fixes opensearch-project#5187

Signed-off-by: Miki <[email protected]>
AMoo-Miki added a commit to AMoo-Miki/OpenSearch-Dashboards that referenced this issue Oct 4, 2023
@AMoo-Miki
Fix visAugmenter forming empty key-value pairs in its calls to the …
6612da6 
…`SavedObject` API

Fixes opensearch-project#5187

Signed-off-by: Miki <[email protected]>
AMoo-Miki added a commit to AMoo-Miki/OpenSearch-Dashboards that referenced this issue Oct 4, 2023
@AMoo-Miki
Fix visAugmenter forming empty key-value pairs in its calls to the …
83f15d9 
…`SavedObject` API

Fixes opensearch-project#5187

Signed-off-by: Miki <[email protected]>
AMoo-Miki added a commit that referenced this issue Oct 4, 2023
@AMoo-Miki
Fix visAugmenter forming empty key-value pairs in its calls to the …
c27d2f5 
…`SavedObject` API (#5190)

Fixes #5187

Signed-off-by: Miki <[email protected]>
opensearch-trigger-bot bot pushed a commit that referenced this issue Oct 4, 2023
@github-actions
Fix visAugmenter forming empty key-value pairs in its calls to the …
4c75a07 
…`SavedObject` API (#5190)

Fixes #5187

Signed-off-by: Miki <[email protected]>
(cherry picked from commit c27d2f5)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md
opensearch-trigger-bot bot pushed a commit that referenced this issue Oct 4, 2023
@github-actions
Fix visAugmenter forming empty key-value pairs in its calls to the …
c0a885f 
…`SavedObject` API (#5190)

Fixes #5187

Signed-off-by: Miki <[email protected]>
(cherry picked from commit c27d2f5)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md
AMoo-Miki added a commit that referenced this issue Oct 4, 2023
@opensearch-trigger-bot @github-actions @AMoo-Miki
Fix visAugmenter forming empty key-value pairs in its calls to the …
f039a55 
…`SavedObject` API (#5190) (#5192)

Fixes #5187

Signed-off-by: Miki <[email protected]>
(cherry picked from commit c27d2f5)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Miki <[email protected]>
willie-hung pushed a commit to willie-hung/OpenSearch-Dashboards that referenced this issue Oct 5, 2023
@AMoo-Miki @willie-hung
Fix visAugmenter forming empty key-value pairs in its calls to the …
4b6cdb3 
…`SavedObject` API (opensearch-project#5190)

Fixes opensearch-project#5187

Signed-off-by: Miki <[email protected]>
Signed-off-by: Willie Hung <[email protected]>
SuZhou-Joe pushed a commit to SuZhou-Joe/OpenSearch-Dashboards that referenced this issue Oct 7, 2023
@AMoo-Miki @SuZhou-Joe
Fix visAugmenter forming empty key-value pairs in its calls to the …
4c2d236 
…`SavedObject` API (opensearch-project#5190)

Fixes opensearch-project#5187

Signed-off-by: Miki <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AMoo-Miki AMoo-Miki

Labels
bug Something isn't working v2.11.0
Projects
None yet
Milestone
No milestone
4 participants
@seraphjiang @seanneumann @AMoo-Miki @ashwin-pc